Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyscaffold breaks with setuptools version 39 #148

Closed
cpaulik opened this issue Mar 19, 2018 · 16 comments
Closed

Pyscaffold breaks with setuptools version 39 #148

cpaulik opened this issue Mar 19, 2018 · 16 comments
Labels
bug Something isn't working

Comments

@cpaulik
Copy link
Contributor

cpaulik commented Mar 19, 2018

I get an error like

      File "/tmp/pip-build-gwh071/damsat/.eggs/PyScaffold-2.5.8-py2.7.egg/pyscaffold/utils.py", line 239, in check_setuptools_version
        "Your setuptools version is too old (<12). "
    RuntimeError: Your setuptools version is too old (<12). Use `pip install -U setuptools` to upgrade.
    If you have the deprecated `distribute` package installed remove it or update to version 0.7.3.

The reason is that SetuptoolsVersion was removed. See https://github.com/pypa/setuptools/blob/master/CHANGES.rst#v3900
@FlorianWilhelm
Copy link
Member

Thanks for reporting. That means one would need to increment the setuptools_scm version to v1.16.0 and use their fix for PyScaffold too or rather import it. I'll be only able to fix this tomorrow afternoon, but looking forward to a PR if you like to.

@FlorianWilhelm FlorianWilhelm added the bug Something isn't working label Mar 19, 2018
@cpaulik
Copy link
Contributor Author

cpaulik commented Mar 19, 2018

I really know too little to be able to make a PR quickly and I don't have time today to do the research.

@JWDobken
Copy link

The issue is not hard to solve, but you and I do not have the permission apparently.

@FlorianWilhelm
Copy link
Member

@JWDobken, you have the permission in the sense that you can create a PR.

@JWDobken
Copy link

I have never ever done this before as well :|, soo
Please find my first open source PR #149 ever

@scorphus
Copy link

I'll create a PR to the v2.x branch. We still use Python 2.

scorphus added a commit to scorphus/pyscaffold that referenced this issue Mar 20, 2018
@scorphus
Use setuptools_scm's VERSION_CLASS to check setuptools version
4f0da44 
This is a fix for issue pyscaffold#148 and based on the following:

pypa/setuptools_scm@4793406
@scorphus scorphus mentioned this issue Mar 20, 2018
Closed
@tlmurphy tlmurphy mentioned this issue Mar 20, 2018
Closed
FlorianWilhelm added a commit that referenced this issue Mar 20, 2018
@FlorianWilhelm
fix issue #148
69e0bed
@FlorianWilhelm
Copy link
Member

Thanks a lot folks for all your support. I just pushed a version 2.5.9rc1 to PyPI, so please check if that works for you and let me know.
@scorphus, thanks for your PR. I saw it a little late and already had something in progress which is quite similar to your solution. I added you to the list of contributors and are looking forward to more contributions from you :-)

@cpaulik
Copy link
Contributor Author

cpaulik commented Mar 20, 2018

Thanks.

It seems to work fine.

But it means I will be upgrading and making new releases for all my older packages that are still based on pyscaffold 2.4.x.

I'm a little annoyed by the setuptools team for removing this just for the sake of changing it to another name.

cpaulik added a commit to TUW-GEO/pygeobase that referenced this issue Mar 20, 2018
@cpaulik
Update to pyscaffold version 2.5.9.
f5d754b 
Fix for pyscaffold/pyscaffold#148
@cpaulik cpaulik mentioned this issue Mar 20, 2018
Merged
cpaulik added a commit to TUW-GEO/pynetcf that referenced this issue Mar 20, 2018
@cpaulik
Update to pyscaffold 2.5.x
fbc356e 
Fix for pyscaffold/pyscaffold#148
@cpaulik cpaulik mentioned this issue Mar 20, 2018
Merged
@scorphus
Copy link

YAY! 🎉 v2.5.9rc1 works like a charm. Thanks, @FlorianWilhelm, not only for the better/more elegant solution 👍 and the new RC but also for adding me as a contributor! I look forward to contributing/learning more 🙂

@FlorianWilhelm
Copy link
Member

Alright, after a switch to version 1.17.0 of setuptools_scm (released today) everything seems to be green again. To test everything out I released two release candidates, v2.5.10rc1 for legacy and v3.0.2rc3 for the current generation of PyScaffold. Please check them out and let me know if you encounter any problems.

@smartsammler
Copy link
Contributor

v3.0.2rc3 works for me. Thank you for this fast release.

@scorphus
Copy link

@FlorianWilhelm, 2.5.10rc1 works well too, thanks for reacting to updates on setuptools_scm so quickly! 👍

@FlorianWilhelm
Copy link
Member

PyScaffold 2.5.10 is released! I incorporated a few more changes into PyScaffold 3.0.2rc4 and give it one more day for testing.

@glebourgeois
Copy link

We tested v3.0.2rc4 it works fine! thanks for the quick reaction, we are eager to see the final release happen :)

@kstuart kstuart mentioned this issue Mar 22, 2018
Closed
@FlorianWilhelm
Copy link
Member

@glebourgeois Thanks for the feedback and the funny title of theQRL/QRL#1046 :-)
Version v3.0.2 was just released. Thanks to everyone in this thread for getting involved and your help!

@scorphus
Copy link

high-five

cpaulik pushed a commit to cpaulik/pyscaffold that referenced this issue Apr 4, 2018
@FlorianWilhelm
Squashed 'pyscaffold/contrib/setuptools_scm/' changes from d041864..7…
4b26e64 
…5897ba

75897ba Merge pull request pyscaffold#168 from RonnyPfannschmidt/fix-167
a9a1bd5 acceptance test and changelog for issue pyscaffold#167
f9dd60a actually pass along preformatted
072c43c switch an assert for a trace
8d995d7 fix spelling of preformatted
26b4942 add forgotten attribute that i missed thanks to local state
8d9c073 try to fix pyscaffold#167 by introducing a preformated flag
00f3fbe Merge pull request pyscaffold#166 from RonnyPfannschmidt/enhanced-self-use
f46e7d7 changelog
6699e5e allow unprepared self-use
34125b8 Merge pull request pyscaffold#165 from RonnyPfannschmidt/fix-164
a9aa2f9 fix python2.6 issue with the new test
3e5cc24 rectify flake8 issues
a7ab513 add a regression test for issue pyscaffold#164
1cfcec1 iterate multiple entrypoints when looking for versions
5bd8bbb update default.nix, reindent
a3bc80d Merge pull request pyscaffold#163 from RonnyPfannschmidt/fix-150
29fc011 strip local components off tags, fixes pyscaffold#150
10d75f6 Merge pull request pyscaffold#161 from jayvdb/patch-1
956334b .travis.yml: Use Python version '3.6'
ee8ce47 Merge pull request pyscaffold#160 from sschuberth/per-scm-prefix
016d71f Use per-SCM node prefix letters instead of the general "n"
83b751c Merge pull request pyscaffold#159 from matejcik/master
15a4992 fix sys.executable failure on Windows
7a0b710 Merge pull request pyscaffold#158 from matejcik/master
d1b9dec use sys.executable instead of 'python' for running regression tests
1b2ea95 Merge pull request pyscaffold#157 from sschuberth/node-g-fallback
6e40668 Fix the node for Git to be prefixed with 'g' also in the fallback
a3d8d09 Merge pull request pyscaffold#156 from sschuberth/prefer-git-describe
9b4aaca Prefer to only use 'git describe' for all required info
af581b0 Update README.rst (pyscaffold#155)
9bd1298 Merge pull request pyscaffold#153 from mehulkar/docs
a5a4892 Add note about git describe
b18c53e Merge pull request pyscaffold#151 from pombredanne/patch-1
7ee6a66 Ensure that LICENSE file is included in wheels
905fe1c Delete .hgtags
e914842 Merge pull request pyscaffold#149 from pypa/appveyor
a0290b0 fix tests for windows paths
05064f7 fix appveyor tox env name
81fce1f Merge pull request pyscaffold#148 from RonnyPfannschmidt/fix-138/pip-egg-info-fallback
f51c6e3 fix pyscaffold#138 - add support for the pip-egg-info folder
8c06ee9 Merge pull request pyscaffold#147 from pypa/master_testscript
9c9fc79 Merge pull request pyscaffold#146 from RonnyPfannschmidt/setup/fix_version
fd87aad fix operator typo and a merge mistake
bac6f0b add extra comments to the travis test script
8c13dfc merge my 2 branches to fix the travis setup and selfinstall testing
8f4da52 fix the version check in the script
dc91584 fix typo
2a24680 fix up ci setup for self-install
7493894 create a new test run script with selfinstall
46991be create a new test run script with selfinstall
809a929 repare v1.15.1
5f33027 fix up changelog
26953a6 ensure we find our own version in a sdist
b0d17f1 Merge pull request pyscaffold#133 from reece/master
5338d77 closes pyscaffold#132: adds instructions for passing dict to use_scm_version
951ad9f Merge pull request pyscaffold#130 from pypa/fix-128
acf760b fix issue pyscaffold#128: return None from missmatched parse calls
a91ac1d Merge pull request pyscaffold#127 from pypa/issue-126
4c8d3d1 Update changelog. Ref pyscaffold#126.
fe4182c Strip any local part of the tag from the version when guessing the next version. Fixes pyscaffold#126.
7f31693 Update test to reflect canonical syntax. Ref pyscaffold#126.
d17972e Extract functions for each bump technique.
2743575 Calculate the suffix in one place.
421fa88 Add test capturing failure. Ref pyscaffold#126.
b84d2a4 Merge pull request pyscaffold#125 from majuscule/suggest-write-to-configuration
9c727ee handle uninstalled pkg in __version__ assignment
0e8739f suggest pkg_resources for __version__ export
4ab48a3 suggest write_to config for pkg distribution
ffef94d Merge pull request pyscaffold#120 from mihaic/fix-sphinx-example
97423d0 Fix Sphinx usage example
9cf2009 Merge pull request pyscaffold#118 from RonnyPfannschmidt/git-shallow
79ddd09 address pyscaffold#93 - experimental tools for interacting with git shallow clones
dccfea9 Merge pull request pyscaffold#119 from RonnyPfannschmidt/fix-81
a446485 fix flake8 transgressions
95de8a6 fix pyscaffold#81 - fail more nice if git/hg is not availiable
3a1f72f fix issue pyscaffold#84 - document sphinx using pkg_resources
5c9d94e update changelog
c6c2bd6 Merge pull request pyscaffold#117 from pypa/dumb-sdist
d75f2b2 Merge pull request pyscaffold#116 from RonnyPfannschmidt/trove
11cbc63 update trove classifiers with supported python versions
6b6c6cf stop being smart for sdist
7bf9e8f Merge pull request pyscaffold#115 from cclauss/patch-2
04c42c3 Simplify clean_scheme()
39aa912 Update changelog
63a122c Merge pull request pyscaffold#111 from petrem/master
b037191 use tag's repr() in string format
b8eb297 use --template instead of -T, the latter was added in mercurial 3.0
dfcebb2 fix mercurial for several tags on changeset and distance only consisting of tag commits
570f7f5 Merge pull request pyscaffold#110 from RonnyPfannschmidt/fix-109
de40adc add CHANGELOG entries
5515c95 fix tests after ensuring distance is 0
7307105 fix oversight - when git node is None, distance should be 0
812b80a ignore untracked files in worktree, fixes pyscaffold#109
f9747f4 add test for pyscaffold#109
7961046 Merge pull request pyscaffold#108 from RonnyPfannschmidt/git-distance-initial
388bd58 fix pyscaffold#107 - dont use node if it is none
5ef809f prepare travis publishing of bdist-egg

git-subtree-dir: pyscaffold/contrib/setuptools_scm
git-subtree-split: 75897ba511010efaabf628217d34b589d9299c8f
cpaulik pushed a commit to cpaulik/pyscaffold that referenced this issue Apr 4, 2018
@FlorianWilhelm
Squashed 'pyscaffold/contrib/setuptools_scm/' changes from d041864..a…
16ba65a 
…6f0878

a6f0878 update changelog
a1b59e6 Merge pull request pyscaffold#172 from anthrotype/fix-tox-ini
f8e3afc tox.ini: don't pin py version; fixes pyscaffold#171
75897ba Merge pull request pyscaffold#168 from RonnyPfannschmidt/fix-167
a9a1bd5 acceptance test and changelog for issue pyscaffold#167
f9dd60a actually pass along preformatted
072c43c switch an assert for a trace
8d995d7 fix spelling of preformatted
26b4942 add forgotten attribute that i missed thanks to local state
8d9c073 try to fix pyscaffold#167 by introducing a preformated flag
00f3fbe Merge pull request pyscaffold#166 from RonnyPfannschmidt/enhanced-self-use
f46e7d7 changelog
6699e5e allow unprepared self-use
34125b8 Merge pull request pyscaffold#165 from RonnyPfannschmidt/fix-164
a9aa2f9 fix python2.6 issue with the new test
3e5cc24 rectify flake8 issues
a7ab513 add a regression test for issue pyscaffold#164
1cfcec1 iterate multiple entrypoints when looking for versions
5bd8bbb update default.nix, reindent
a3bc80d Merge pull request pyscaffold#163 from RonnyPfannschmidt/fix-150
29fc011 strip local components off tags, fixes pyscaffold#150
10d75f6 Merge pull request pyscaffold#161 from jayvdb/patch-1
956334b .travis.yml: Use Python version '3.6'
ee8ce47 Merge pull request pyscaffold#160 from sschuberth/per-scm-prefix
016d71f Use per-SCM node prefix letters instead of the general "n"
83b751c Merge pull request pyscaffold#159 from matejcik/master
15a4992 fix sys.executable failure on Windows
7a0b710 Merge pull request pyscaffold#158 from matejcik/master
d1b9dec use sys.executable instead of 'python' for running regression tests
1b2ea95 Merge pull request pyscaffold#157 from sschuberth/node-g-fallback
6e40668 Fix the node for Git to be prefixed with 'g' also in the fallback
a3d8d09 Merge pull request pyscaffold#156 from sschuberth/prefer-git-describe
9b4aaca Prefer to only use 'git describe' for all required info
af581b0 Update README.rst (pyscaffold#155)
9bd1298 Merge pull request pyscaffold#153 from mehulkar/docs
a5a4892 Add note about git describe
b18c53e Merge pull request pyscaffold#151 from pombredanne/patch-1
7ee6a66 Ensure that LICENSE file is included in wheels
905fe1c Delete .hgtags
e914842 Merge pull request pyscaffold#149 from pypa/appveyor
a0290b0 fix tests for windows paths
05064f7 fix appveyor tox env name
81fce1f Merge pull request pyscaffold#148 from RonnyPfannschmidt/fix-138/pip-egg-info-fallback
f51c6e3 fix pyscaffold#138 - add support for the pip-egg-info folder
8c06ee9 Merge pull request pyscaffold#147 from pypa/master_testscript
9c9fc79 Merge pull request pyscaffold#146 from RonnyPfannschmidt/setup/fix_version
fd87aad fix operator typo and a merge mistake
bac6f0b add extra comments to the travis test script
8c13dfc merge my 2 branches to fix the travis setup and selfinstall testing
8f4da52 fix the version check in the script
dc91584 fix typo
2a24680 fix up ci setup for self-install
7493894 create a new test run script with selfinstall
46991be create a new test run script with selfinstall
809a929 repare v1.15.1
5f33027 fix up changelog
26953a6 ensure we find our own version in a sdist
b0d17f1 Merge pull request pyscaffold#133 from reece/master
5338d77 closes pyscaffold#132: adds instructions for passing dict to use_scm_version
951ad9f Merge pull request pyscaffold#130 from pypa/fix-128
acf760b fix issue pyscaffold#128: return None from missmatched parse calls
a91ac1d Merge pull request pyscaffold#127 from pypa/issue-126
4c8d3d1 Update changelog. Ref pyscaffold#126.
fe4182c Strip any local part of the tag from the version when guessing the next version. Fixes pyscaffold#126.
7f31693 Update test to reflect canonical syntax. Ref pyscaffold#126.
d17972e Extract functions for each bump technique.
2743575 Calculate the suffix in one place.
421fa88 Add test capturing failure. Ref pyscaffold#126.
b84d2a4 Merge pull request pyscaffold#125 from majuscule/suggest-write-to-configuration
9c727ee handle uninstalled pkg in __version__ assignment
0e8739f suggest pkg_resources for __version__ export
4ab48a3 suggest write_to config for pkg distribution
ffef94d Merge pull request pyscaffold#120 from mihaic/fix-sphinx-example
97423d0 Fix Sphinx usage example
9cf2009 Merge pull request pyscaffold#118 from RonnyPfannschmidt/git-shallow
79ddd09 address pyscaffold#93 - experimental tools for interacting with git shallow clones
dccfea9 Merge pull request pyscaffold#119 from RonnyPfannschmidt/fix-81
a446485 fix flake8 transgressions
95de8a6 fix pyscaffold#81 - fail more nice if git/hg is not availiable
3a1f72f fix issue pyscaffold#84 - document sphinx using pkg_resources
5c9d94e update changelog
c6c2bd6 Merge pull request pyscaffold#117 from pypa/dumb-sdist
d75f2b2 Merge pull request pyscaffold#116 from RonnyPfannschmidt/trove
11cbc63 update trove classifiers with supported python versions
6b6c6cf stop being smart for sdist
7bf9e8f Merge pull request pyscaffold#115 from cclauss/patch-2
04c42c3 Simplify clean_scheme()
39aa912 Update changelog
63a122c Merge pull request pyscaffold#111 from petrem/master
b037191 use tag's repr() in string format
b8eb297 use --template instead of -T, the latter was added in mercurial 3.0
dfcebb2 fix mercurial for several tags on changeset and distance only consisting of tag commits
570f7f5 Merge pull request pyscaffold#110 from RonnyPfannschmidt/fix-109
de40adc add CHANGELOG entries
5515c95 fix tests after ensuring distance is 0
7307105 fix oversight - when git node is None, distance should be 0
812b80a ignore untracked files in worktree, fixes pyscaffold#109
f9747f4 add test for pyscaffold#109
7961046 Merge pull request pyscaffold#108 from RonnyPfannschmidt/git-distance-initial
388bd58 fix pyscaffold#107 - dont use node if it is none
5ef809f prepare travis publishing of bdist-egg

git-subtree-dir: pyscaffold/contrib/setuptools_scm
git-subtree-split: a6f0878a67e6c2eb91ba4db1bbeb5f6c759bca00
@rparini rparini mentioned this issue Apr 11, 2018
Closed
@aspiers aspiers mentioned this issue May 16, 2018
Open
aspiers added a commit to aspiers/git-deps that referenced this issue May 16, 2018
@aspiers
avoid PyScaffold bug with newer setuptools
64071eb 
pyscaffold/pyscaffold#148

Why the HELL is setup_requires choosing to install PyScaffold 2.5.6
when 2.5.10 is available and within the constraints?  That would be
far too sensible, wouldn't it?
aspiers added a commit to aspiers/git-explode that referenced this issue May 16, 2018
@aspiers
avoid PyScaffold bug with newer setuptools
796ab3b 
pyscaffold/pyscaffold#148

Why the HELL is setup_requires choosing to install PyScaffold 2.5.6
when 2.5.10 is available and within the constraints?  That would be
far too sensible, wouldn't it?
aspiers added a commit to aspiers/git-explode that referenced this issue May 17, 2018
@aspiers
avoid PyScaffold bug with newer setuptools
ab1ec51 
pyscaffold/pyscaffold#148

Why the HELL is setup_requires choosing to install PyScaffold 2.5.6
when 2.5.10 is available and within the constraints?  That would be
far too sensible, wouldn't it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@smartsammler @cpaulik @glebourgeois @scorphus @FlorianWilhelm @JWDobken