Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy 0.9.x compatibility #12

Closed
jank opened this issue Mar 31, 2014 · 3 comments
Closed

Fix SQLAlchemy 0.9.x compatibility #12

jank opened this issue Mar 31, 2014 · 3 comments

Comments

@jank
Copy link

jank commented Mar 31, 2014

Build with SQLAlchemy 0.9.x fails. Go through the change log and migration guide to determine what is necessary to support 0.8.x and 0.9.x in parallel:

http://docs.sqlalchemy.org/en/rel_0_9/changelog/migration_09.html
http://docs.sqlalchemy.org/en/latest/changelog/changelog_09.html

@jank
Copy link
Author

jank commented May 30, 2014

Done several fixes to get to 0.9.4 support. The test suite covers more aspects of the dialect and uncovered some glitches in identifier preparing (identifiers with leading _ were not quoted, retrieval of the row_id was incorrect). Waiting for one pull request to be merged and released with sqla:
zzzeek/sqlalchemy#95
String test incorrectly references Text type.

@jank
Copy link
Author

jank commented May 30, 2014

Switching to 0.9.x requires to switch to py.test. Support for py.test was only added with 0.9. Hence, 0.8 cannot be supported anymore. All users must upgrade to sqla 0.9

@jank
Copy link
Author

jank commented May 30, 2014

Done, nose test support removed. No test for 0.8.x possible.

@jank jank closed this as completed May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant