Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependece upon matrixprofile #972

Closed
erezinman opened this issue Oct 19, 2022 · 7 comments
Closed

Dependece upon matrixprofile #972

erezinman opened this issue Oct 19, 2022 · 7 comments
Assignees
Labels

Comments

@erezinman
Copy link

Hi,
It seems that the package matrixprofile is no longer maintained. The package forces a specific and deprecated version of protobuf, and hence is incompatible with many packages (tensorflow, pytorch, etc.). Please remove the dependence upon matrixprofile, or, at least, make this package's installation optional (maybe using extras_require in the setup.py?).

@erezinman erezinman added the bug label Oct 19, 2022
@arturdaraujo
Copy link

arturdaraujo commented Oct 19, 2022

I fully agree. When creating an environment with pyarrow on python 3.7+ I had the same compatibility problem. Pyarrow is used for importing parquet and feather files which makes this incompatibility quite annoying for people who don't use csv.


(base) C:\Users\artur>conda create -n env_tsfresh36 python=3.9 spyder tsfresh=0.19 pyarrow
...
Collect all metadata (repodata.json): done
Solving environment: failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package tsfresh-0.19.0-pyhd8ed1ab_0 requires matrixprofile >=1.1.10,<2.0.0, but none of the providers can be instald

@aiwalter
Copy link

aiwalter commented Nov 1, 2022

Hi together, we are having same issue and would appreciate a solution here with a new tsfresh release!

@PJPRoche
Copy link

PJPRoche commented Nov 1, 2022

Hello, I am having the same issues with matrixprofile too. I raised an issue in their GitHub repo (matrix-profile-foundation/matrixprofile#102) with a suggestion to fix the issue, but there has not been any activity for a long time.
Would be great of the dependency can be removed here

@kempa-liehr kempa-liehr self-assigned this Nov 1, 2022
@williamgilpin
Copy link

Hello, thank you very much for this incredible package. We are also having this issue, and have not yet been able to find a workaround.

How many of the features depend on matrixprofile? Would it be possible to drop those features for now (and thus the dependency) until an alternative like stumpy is implemented?

@arturdaraujo
Copy link

Any news on this issue @kempa-liehr ? This update would be incredibly helpful!

@enrique-wesper
Copy link

It would be amazing to be able to install tsfresh. I am using a mac M2 and I have also not been able to find a workaround

@kempa-liehr
Copy link
Collaborator

Fixed in https://github.com/blue-yonder/tsfresh/tree/v0.20.0.
Many thanks for your patience and perseverance.

Merry Christmas and a Happy New Year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants