New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unmaintained dependency matrixprofile
makes tsfresh
uninstallable on python 3.10
#991
Comments
matrixprofile
makes tsfresh
uninstallable on python 3.10matrixprofile
makes tsfresh
uninstallable on python 3.10
Let's help @kempa-liehr fix this. SOLUTIONS:
Anyone familiar on how to use extras_require in the setup.py to make matrixprofile optional? Anyone able to post a code that would replace matrixprofile functions on tsfresh? I will have a go and post it here @erezinman @aiwalter @PJPRoche @williamgilpin @enrique-wesper |
Making matrixprofile package optional:
For making matrixprofile optional, the setup.py solution is like this:
Note: "matrix_profile" is a tsfresh function, while "matrixprofile" is the outdated package in question.
And
After the implementation on feature_calculators.py, the only thing needed would be to place a I hope this answer is clear enough to give a sense of how to fix this. If it is too convoluted or it could be improved please point it out. References:
|
@arturdaraujo Just separate the Also, you could simply import the package normally, but wrap this with |
I also think Thanks for the reply |
I just realized that there is a PR #985 @kempa-liehr @erezinman @aiwalter @PJPRoche @williamgilpin @enrique-wesper @mmp3 @bvanelli @michaelosthege |
PR has been merged and a new version 0.20.0 released :) |
@nils-braun great! should we also update it here? Lines 10 to 30 in d059eec
|
Thanks @aiwalter ! I have added py 3.10 as a classifier. I have not added an upper bound to the |
@nils-braun I still cannot use tsfresh with python 3.10.9. I am getting the following error: I am using the main branch with latest commit 2e49614 |
Indeed I was importing from sktime
|
The problem:
tsfresh
cannot be installed onpython 3.10
because it hasmatrixprofile
as a dependency, yetmatrixprofile
cannot be installed onpython 3.10
and is no longer maintained.Anything else we need to know?:
matrixprofile
is superseded bystumpy
.Environment:
The text was updated successfully, but these errors were encountered: