Make Dask and Distributed optional dependencies #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-braun
reviewed
Jan 27, 2024
Dask was de facto optional already (see the guarded import in
tsfresh/feature_extraction/data.py), but before this commit it was
installed by default.
Distributed is imported only to support Dask, when the classes
ClusterDaskDistribution or LocalDaskDistribution are used, so it is not
needed if Dask is not imported.
To install tsfresh with those dependencies, one can do:
pip install -e ".[dask]"
This is needed, for example, to run the test suite. The documentation
has been updated accordingly.
lifepillar
force-pushed
the
optional-dask-distributed
branch
from
154504a
to
b96d84f
Compare
nils-braun
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Thanks @lifepillar! I just changed the "tsfresh[dask]" to "%(dask)s" in the setup.cfg, because it is more general - but other than that LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 93.43% 93.85% +0.42%
==========================================
Files 20 20
Lines 1888 1888
Branches 372 372
==========================================
+ Hits 1764 1772 +8
+ Misses 85 78 -7
+ Partials 39 38 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1060.
Dask was de facto optional already (see the guarded import in
tsfresh/feature_extraction/data.py), but before this PR it was installed by default.Distributed is imported only to support Dask, when the classes
ClusterDaskDistributionorLocalDaskDistributionare used, so it is not needed if Dask is not imported.To install tsfresh with those dependencies, one can do:
This is needed, for example, to run the test suite.The documentation has been updated accordingly.