I8 add python3 support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed xrange to range for #8 * Modified csort due to range changing from list to type for #8 * Use assertItemsEqual py2 and assertCountEqual py3 Due to a change in unittest in as identified by @jneuff in #8 (comment) Semantically they appear to be the same and this fixes the related failing tests on Python 3.5 as described in the gist in #8 (comment) Adds a basic method to determine python version for now, only committing so that the new deeper unitest.assertEqual issue that now presents itself can be addressed.
__dict__ will give iterator for properties
fixes bug #29, features with multiple, but same parameters could end up with different names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.