Skip to content

Commit

Permalink
update the arrow install requirements to limit it only downwards to >…
Browse files Browse the repository at this point in the history
…=0.17.1 (#293)

* update the arrow install requirements to limit it only downwards to >=0.17.1

the test pipelines work for arrow >=3.0.0 as well so we should allow
it for install as well

* update CHANGELOG to represent change to the arrow install requirements which allow arrow>=0.17.1 with no upper limit

* add upper limit for arrow<3.1.0 to reduce risk of use of a breaking arrow version

decided to use <3.1.0 as this would allow the use of 3.x.x but also
limit it to bugfix releases

* limit tests with arrow 3.x.x to <3.1.0 to be aligned with setup.py install requirements

* Update CHANGELOG.rst to represent arrow<3.1

Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>

Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
  • Loading branch information
bjoernmeier and xhochy committed Feb 10, 2021
1 parent 3d4c62b commit f14f546
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ From version 2.0.0, turbodbc adapts semantic versioning.
Version 4.1.2
-------------

* Update package requirements so pyarrow<2.0 can be used.
* Update package requirements so pyarrow>0.17.1,<3.1 can be used.

Version 4.1.1
-------------
Expand Down
2 changes: 1 addition & 1 deletion Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ test-python3.8-arrow1.x.x:
test-python3.8-arrow2.x.x:
ARG PYTHON_VERSION="3.8.5"
COPY --build-arg PYTHON_VERSION="$PYTHON_VERSION" \
--build-arg ARROW_VERSION_RULE=">=2,<3" \
--build-arg ARROW_VERSION_RULE=">=2,<3.1" \
--build-arg NUMPY_VERSION_RULE=">=1.20.0" \
+test/result /result

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def get_extension_modules():
author_email = 'michael.koenig@blue-yonder.com',
packages = ['turbodbc'],
extras_require={
'arrow': ['pyarrow>=0.15,<2.0'],
'arrow': ['pyarrow>=0.15,<3.1.0'],
'numpy': 'numpy>=1.16.0'
},
classifiers = ['Development Status :: 5 - Production/Stable',
Expand Down

0 comments on commit f14f546

Please sign in to comment.