Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml to build artifact to meet pep517 #401

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

cshaley
Copy link
Contributor

@cshaley cshaley commented Nov 16, 2023

pyproject.toml was missing in the tar.gz build artifact. This caused the command pip wheel --use-pep517 "turbodbc==4.8.0" to fail.

I verified the problem with the below commands and then tested the change the same way.

cmake -DBOOST_ROOT=$CONDA_PREFIX -DBUILD_COVERAGE=ON -DCMAKE_INSTALL_PREFIX=./dist -DPYTHON_EXECUTABLE=$(which python) -GNinja .. && ninja && cmake --build . --target install && cd dist && python setup.py sdist

pip wheel --use-pep517 "dist/turbodbc-4.9.0.tar.gz"

@cshaley cshaley requested a review from xhochy as a code owner November 16, 2023 20:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7b3f1e) 98.81% compared to head (5776003) 98.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          94       94           
  Lines        3030     3030           
=======================================
  Hits         2994     2994           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xhochy xhochy merged commit 28baf98 into blue-yonder:master Nov 18, 2023
40 checks passed
@rxm7706
Copy link

rxm7706 commented Nov 18, 2023

@cshaley @xhochy thank you !
I really wonder how many people care about PiP and conda packages releases being available to everyone as soon as possible - especially when a CVE is found and patched by upstream maintainers so quickly.

But I'm glad to see how fast the Pyarrow contributors reacted, and we are close to having both TurboODBC and ML-Flow patched and available for use through PiP, Poetry and Conda. Thank you for your time,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants