-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
2928 lines (1878 loc) · 99.9 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2011-04-21 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.7.
* META, NEWS, conman.spec: Updated metadata for 0.2.7 release.
* server-ipmi.c (parse_ipmi_opts): Fixed snprintf() format warning.
* server.c (reset_console): Added cast to execl() NULL ptr arg to
resolve "missing sentinel in function call" warning on OpenBSD-4.7.
2011-04-20 Chris Dunlap <cdunlap@llnl.gov>
* : Added support for new IPMIOPTS syntax. (Fixes issue 5)
* server-ipmi.c (parse_ipmi_opts): Rewrote for new ipmiopts syntax.
* server-ipmi.c (init_ipmi_opts, parse_ipmi_opts_v1, process_ipmi_opt,
is_ipmi_opt_tag, process_ipmi_opt_username,
process_ipmi_opt_password, process_ipmi_opt_k_g,
process_ipmi_opt_privilege, process_ipmi_opt_cipher,
process_ipmi_opt_workaround): Added.
* server-ipmi.c (create_ipmi_obj): Added DPRINTF to dump ipmiopts.
* server-ipmi.c (create_ipmi_ctx): Updated to use new ipmiopts.
* server-conf.c (create_server_conf):
Replaced memset() of globalIpmiOpts with init_ipmi_opts().
* server.h: Added privilegeLevel, cipherSuite, and workaroundFlags to
struct ipmi_opt.
* etc/conman.conf, man/conman.conf.5.in: Documented new ipmiopts.
* configure.ac: Updated tests to require freeipmi-1.0.4 or later.
* conman.spec: Updated BuildRequires for freeipmi-devel.
2011-04-07 Chris Dunlap <cdunlap@llnl.gov>
* server.h, server-conf.c, server-ipmi.c, server-process.c,
server-serial.c, server-telnet.c, server-unixsock.c:
Moved is_ipmi_dev(), is_process_dev(), is_serial_dev(),
is_telnet_dev(), and is_unixsock_dev() out of server-conf.c.
2011-04-06 Chris Dunlap <cdunlap@llnl.gov>
* configure.ac: Fixed "--enable-debug" building when CFLAGS are set.
Added DEBUG_CFLAGS substitution.
* Makefile.in: Added DEBUG_CFLAGS to COMPILE_OPTS.
* tpoll.h: Removed comma at end of tpoll_zero_t enumerator list
in order to build with -pedantic.
* : Cleaned up preprocessor conditionals.
2011-04-05 Chris Dunlap <cdunlap@llnl.gov>
* configure.ac: Combined adjacent AC_CHECK_HEADERS.
* configure.ac: Made "--with-freeipmi" fatal if FreeIPMI not found.
* configure.ac: Replaced AC_HELP_STRING with AS_HELP_STRING.
2011-04-04 Chris Dunlap <cdunlap@llnl.gov>
* configure.ac: Fixed spurious quote in AC_CHECK_DECL.
* conman.spec: Added freeipmi-devel version to BuildRequires tag.
* server.c (main): Changed default log priority to LOG_INFO.
* : Fixed race conditions & segfaults when using libipmiconsole.
Added mutex to protect against concurrent access to the ipmi_obj
since connect_ipmi_obj() can be invoked from either the main
thread or the ipmiconsole engine thread. (Fixes issue 7)
* configure.ac: Changed ipmiconsole autoconf tests to indirectly check
for FreeIPMI 1.0.3+ which fixes ipmiconsole_engine_submit() behavior.
* server.h: Added mutex to struct ipmi_obj.
* server-obj.c (destroy_obj): Added call to destroy ipmi mutex.
* server-ipmi.c (create_ipmi_obj, open_ipmi_obj, disconnect_ipmi_obj,
connect_ipmi_obj, reset_ipmi_delay, send_ipmi_break): Added support
for ipmi mutex to protect the ctx, state, timer, and delay vars.
* server-ipmi.c (disconnect_ipmi_obj, fail_ipmi_connect):
Removed calls to ipmiconsole_ctx_destroy(). An existing ctx
is now destroyed immediately before a new one is created
in create_ipmi_ctx(). According to Al Chu (FreeIPMI),
ipmiconsole_ctx_destroy() should be safe to call in these places.
This change is more of a precautionary measure. With the ctx now
being destroyed in create_ipmi_ctx(), these other calls should
be redundant.
* server-ipmi.c (create_ipmi_ctx): Destroy an existing ipmi.ctx
immediately before creating a new one.
2011-01-31 Chris Dunlap <cdunlap@llnl.gov>
* THANKS: Updated.
2011-01-26 Chris Dunlap <cdunlap@llnl.gov>
* configure: Autoreconf'd with autoconf-2.67.
* : Applied patch from <marc.girard@bull.net> to add console logfile
lock/nolock option to toggle write lock. (Fixes issue 6)
* server.h: Added enableLock to struct logfile_opt.
* server-conf.c (create_server_conf): Initialized enableLock.
* server-logfile.c (parse_logfile_opts, open_logfile_obj):
Set/Test enableLock for console logfile write lock.
* etc/conman.conf, man/conman.conf.5.in: Documented lock/nolock opt.
* THANKS: Updated.
* : Updated copyright date range.
2010-06-15 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.6.
* META, NEWS, conman.spec: Updated metadata for 0.2.6 release.
* server.h: Removed WITH_FREEIPMI #ifdef guard for CONMAN_OBJ_IPMI.
Replaced conditional def for is_ipmi_obj() with constant def.
Re-ordered is_console_obj().
* : Ported to FreeBSD 4.7-RELEASE-p28 (i386).
* configure.ac: Fixed AC check for socklen_t.
* configure.ac: Added AC check for how to link against Pthreads.
* Makefile.in: Replaced "-lpthread" with $LIBPTHREAD.
* configure, config.h.in: Rebuilt.
* client-sock.c, server.h, server-sock.c, server-telnet.c,
server-unixsock.c, util-net.c: Twiddled header includes for BSD.
* server-obj.c (create_obj): Replaced assert for checking "type" arg
with runtime check against CONMAN_OBJ_LAST_ENTRY due to
"preprocessing directive not recognized within macro arg" warning.
2010-06-08 Chris Dunlap <cdunlap@llnl.gov>
* : Changed license from GPLv2+ to GPLv3+.
* : Changed external process reconnect behavior from
linear-backoff with a max-count leading to a disabled state,
to an exponential-backoff with no max-count. (Fixes issue 3)
* server.h: Added process_obj delay and state, and removed count.
Added PROCESS_MAX_TIMEOUT. Removed PROCESS_MAX_COUNT.
* server.c (mux_io):
Added checks for process obj state when recomputing poll set.
* server-obj.c (write_obj_data, write_to_obj):
Added checks for process obj state.
* server-process.c: Revamped. Refactored open_process_obj()
into disconnect_process_obj() and connect_process_obj().
Added check_process_prog() and reset_process_delay().
* auxdir/config.guess, auxdir/config.sub:
Updated to autotools-dev-20100122.1 (Debian Squeeze).
* auxdir/install-sh, auxdir/mkinstalldirs:
Updated to automake-1.11 (Debian Squeeze).
2010-06-07 Chris Dunlap <cdunlap@llnl.gov>
* server-obj.c: Added DPRINTFs to show start of various routines.
2010-06-03 Chris Dunlap <cdunlap@llnl.gov>
* server.h, server.c, server-obj.c, server-sock.c, server-telnet.c:
Renamed telnet_obj conState to state. Renamed telnet_connect_state
enums from CONMAN_TELCON_* to CONMAN_TELNET_*.
2010-06-02 Chris Dunlap <cdunlap@llnl.gov>
* configure, config.h.in: Autoreconf'd with autoconf-2.65.
* THANKS: Updated.
* server-ipmi.c (complete_ipmi_connect): Tweaked ordering so IPMI state
is reset before a timer is added. This should have no effect other
than to better mirror the other console backends.
* server-ipmi.c (complete_ipmi_connect):
Applied patch from <matthieu.perotin@bull.net> to reset gotEOF flag
upon successful ipmiconsole connection. (Fixes issue 2)
* server-ipmi.c (fail_ipmi_connect):
Applied patch from <matthieu.perotin@bull.net> to cleanup ipmiconsole
ctx on failed connection attempt. (Fixes issue 1)
2010-05-20 Chris Dunlap <cdunlap@llnl.gov>
* README: Added license info and homepage URL.
* etc/conman.conf, man/conman.conf.5.in: Tweaked formatting in
Console Directives section.
2010-05-17 Chris Dunlap <cdunlap@llnl.gov>
* : Updated homepage URL and copyleft boilerplate.
2009-05-19 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.5.
* META, NEWS: Updated for 0.2.5 release.
* server.c (coredump_handler): Moved log_msg() to top of handler.
* server-telnet.c (send_telnet_cmd): Suppressed unused var warning.
* FAQ: Updated info on increasing nofile hard limit.
2009-05-18 Chris Dunlap <cdunlap@llnl.gov>
* man/conman.conf.5.in: Tweaked formatting.
* server.c (coredump_handler): Set restricted umask().
2009-05-16 Chris Dunlap <cdunlap@llnl.gov>
* server.c (setup_coredump, coredump_handler): Added coredumpdir
location to final log msg.
2009-05-14 Chris Dunlap <cdunlap@llnl.gov>
* META, NEWS: Updated.
* server.c (coredump_handler): Added void cast to kill().
* server.c (main, begin_daemonize, setup_coredump, setup_signals,
coredump_handler, display_configuration), server-conf
(create_server_conf, destroy_server_conf, parse_server_directive),
server.h: Added support for 'server coredump' & 'server coredumpdir'
config directives.
* etc/conman.conf, man/conman.conf.5.in: Documented new directives.
* server.c (get_sane_env): Added static keyword to function definition.
2009-05-12 Chris Dunlap <cdunlap@llnl.gov>
* server.c (mux_io): Added #ifdef guard around ipmi obj test.
* server-obj.c (read_from_obj, write_obj_data): Fixed bug with objects
being trapped in a gotEOF state.
* server.c (mux_io): Fixed bug with POLLOUT being set in disconnected
objects having buffered data to send.
2009-05-11 Chris Dunlap <cdunlap@llnl.gov>
* server-telnet.c: Allowed telnet opts not recognized by TELOPT_OK
since my telnet.h doesn't list the newer telnet options.
2009-04-21 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.4.1.
* META, NEWS: Updated for 0.2.4.1 release.
* log.c, log.h: Renamed dprintf() to debug_printf(). The old function
name conflicted with the GNU dprintf() routine for printing to a file
descriptor. Supposedly, this GNU extension will be specified in the
next POSIX.1 revision. Since the old name was now causing problems
with gcc-4.4 builds on fc11, it has been renamed.
2009-04-14 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.4.
* META, NEWS: Updated for 0.2.4 release.
* conman.spec: Changed BuildRoot to work under AIX-5.2.
2009-04-09 Chris Dunlap <cdunlap@llnl.gov>
* conman.spec: Fixed %files entry for /etc/{default,sysconfig}/conman.
* META, NEWS: Updated for 0.2.4-0.pre2.
* lib/exec/sun-v20z-v40z.exp: Tweaked header comments.
* lib/exec/sun-v20z-v40z.exp: Added.
* lib/exec/ibm-bc.exp: Tweaked header comments.
2009-04-08 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/sun-elom.exp: Tweaked header comments.
2009-04-06 Chris Dunlap <cdunlap@llnl.gov>
* conman.spec: Tweaked %files %defattr.
* conman.spec: Tweaked %preun & %postun init script invocation.
* conman.spec: Tweaked %install "make install" line.
* conman.spec: Replaced $RPM_BUILD_ROOT with %{buildroot}.
* conman.spec: Updated %build "make" to use %{?_smp_mflags}.
* conman.spec: Updated BuildRoot to use mktemp.
* conman.spec: Added test for %{_initrddir}. Updated %files.
2009-04-02 Chris Dunlap <cdunlap@llnl.gov>
* etc/conman.init.in: Added Description LSB header.
* etc/conman.init.in: Changed LSB Default-Start / Default-Stop and
chkconfig runlevels so daemon is not started by default.
* etc/conman.init.in: Swapped order of CONFIG & DAEMON_ARGS vars.
2009-04-01 Chris Dunlap <cdunlap@llnl.gov>
* conman.spec: Changed License field from "GPL" to "GPLv2+".
The license has always been GPLv2+, and this change is just
updating the RPM field.
2009-03-30 Chris Dunlap <cdunlap@llnl.gov>
* man/conmand.8.in: Updated security section.
* lib/exec/sun-elom.exp:
Added patch from Dave Love <d.love@liverpool.ac.uk> for
permission-denied and in-use error patterns in Sun ELOM driver.
2009-03-26 Chris Dunlap <cdunlap@llnl.gov>
* log.c (log_err): Replaced void cast of write() in order to silence
rhel5 warning of [ignoring return value of 'write', declared with
attribute warn_unused_result].
* conman.spec: Added rpm conditionals to BuildRequires for
freeipmi-devel and (tcp_wrappers|tcp_wrappers-devel|tcpd-devel).
* man/conmand.8.in: Added note regarding "too many open files" errors.
2009-03-24 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/sun-elom.exp: Added patch from
Dave Love <d.love@liverpool.ac.uk> for Sun ELOM driver.
* THANKS: Updated.
2009-03-02 Chris Dunlap <cdunlap@llnl.gov>
* conmen: Removed 0.2s delay between the spawning of each xterm.
* conmen: Changed xterm geometry option from "-g" to "-G".
Added support for genders nodeattr query via "-g".
2009-02-12 Chris Dunlap <cdunlap@llnl.gov>
* README, conman.spec: Tweaked description.
* META, NEWS: Updated for 0.2.4-0.pre1.
* conman.spec: Added BuildRequires for freeipmi-devel.
* : Updated copyright date range.
* : Merged r758:900 (2007-08-03 to 2009-02-12) from
conman-0.2.1-libipmiconsole branch. Original patch from Levi Pearson
<https://mail.gna.org/public/conman-users/2007-08/msg00000.html>.
2008-12-03 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.3.
* META, NEWS: Updated for 0.2.3 release.
* common.h: Reverted MAX_BUF_SIZE to 8192.
2008-12-02 Chris Dunlap <cdunlap@llnl.gov>
* util-file.c (get_dir_name): Removed redundant assert().
* util-file.c (get_dir_name): Added len check for integer overflow.
* util-file.c (get_dir_name): Changed len type to int.
* server.c (open_daemon_logfile), server-conf.c (write_pidfile),
server-logfile.c (open_logfile_obj): Added creation of intermediate
directories.
* server-conf.c (parse_server_directive): Removed code that ignored
LOGDIR if the directory did not already exist since intermediate
directories are now created.
* etc/conman.conf, man/conman.conf.5.in: Updated documentation.
* util-file.c, util-file.h: Added get_dir_name() and create_dirs().
2008-10-13 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/hp-lo100.exp: Added patch for HP lo100 "Lights Out 100"
driver from Christopher D. Maestas <cdmaestas@comcast.net>.
* THANKS: Updated.
2008-09-03 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.2.
* README, conman.spec: Tweaked description.
* META, NEWS: Updated for 0.2.2 release.
* common.h: Increased MAX_BUF_SIZE from 8192 to 10240.
2008-08-30 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/hp-ilo.exp: Increased timeout to 5s for interact block.
Tweaked patterns to disable "ESC (" sequence.
2008-08-28 Chris Dunlap <cdunlap@llnl.gov>
* inevent.c (inevent_process): Changed type of inotify event buffer
variable 'i' from signed to unsigned since: 0 <= i < len.
* NEWS, THANKS: Updated.
* lib/exec/hp-ilo.exp: Added console script for HP iLO.
* inevent.c (_inevent_destroy): Fixed bug where the function prototype
had two arguments and was used as a list destructor which can take
only one argument. All callers changed.
* inevent.c (inevent_process): Removed all inevents associated with a
given watch descriptor upon receipt of IN_IGNORED.
* inevent.c (inevent_remove): Changed behavior so it is not an error
if 'pathname' is not registered or if the inevent subsystem is down.
2008-08-25 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ibm-bc.exp: Tweaked case for "target bay is empty" pattern.
Added test to return "no blade in specified slot" error in response
to the console cmd, while allowing a "target bay is empty" response
to be safely ignored if encountered while incrementing bcmm_bay
during the telnetcfg cmds.
2008-08-24 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ibm-bc.exp: Tweaked pattern for "Command cannot be issued to
this target". The new src text is "Command cannot be issued to this
target. Type env -h for help on changing\r\ntargets.\r\n".
Truncated pattern before the first CR/LF to maintain backwards
compatibility. Patch from Py Watson.
2008-08-21 Chris Dunlap <cdunlap@llnl.gov>
* server-telnet.c (open_telnet_obj): Reverted change from 2008-07-17
which broke telnet connections. It seems the bug was in the comment.
* inevent.c: Added FIXME for cases not handled by the current code.
* NEWS: Updated.
* inevent.c (inevent_process): Added DPRINTF to dump contents of
inotify_event struct.
* inevent.c (_inevent_destroy): Renamed 'is_unique_wd' parmameter to
'is_wd_unique'.
* inevent.c (_list_find_by_path, _list_find_by_wd,
_list_find_by_event): Added assert()s.
* inevent.c: Tweaked spacing.
2008-08-20 Chris Dunlap <cdunlap@llnl.gov>
* inevent.c: Added comment for stubbed routines.
* inevent.c (inevent_remove): Added comment.
* inevent.c (inevent_remove): Removed use of inevent_loop_ptr var since
it was never subsequently used after being set.
* configure.ac: Added header check for <sys/inotify.h>.
* inevent.c, inevent.h: Added.
* server.c (mux_io): Added checks for inevents.
* server-unixsock.c (create_unixsock_obj): Added call to register
inevents for unixsock objs.
* server-obj.c (destroy_obj): Added call to unregister inevents for
unixsock objs.
2008-08-14 Chris Dunlap <cdunlap@llnl.gov>
* server.c: Changed type of signal handler flags to sig_atomic_t.
2008-08-12 Chris Dunlap <cdunlap@llnl.gov>
* server-obj.c (shutdown_obj): Fixed bug where bufInPtr & bufOutPtr
were accessed without holding guarding lock.
* server.c (reopen_logfiles): Fixed bug where open_daemon_logfile()
could be invoked when conf->logFileName was NULL.
* server.c: Removed unnecessary header wrapper.h.
2008-08-06 Chris Dunlap <cdunlap@llnl.gov>
* server.c: Added volatile qualifier to signal handler flags.
2008-07-17 Chris Dunlap <cdunlap@llnl.gov>
* : Merged r811:816 (2008-01-10 to 2008-01-14) from conman-0.2.1-echo
branch for feature request to enable local echo for serial
connections. However, this merge only enables echo at the client
and not the server (so it is not tied to serial devices, logs are
unaffected, etc.) -- not the ideal solution. Note that the changes
from r810 have been omitted since they didn't seem to work and I was
unable to continue without further feedback from the user.
* server-telnet.c (open_telnet_obj): Fixed bug where calling
open_telnet_obj() in the PENDING state would be misinterpreted
as the completion of the non-blocking connect.
* server.c (mux_io): Added test for !gotEOF before setting POLLIN.
* server-obj.c (read_from_obj): Set gotEOF flag upon reading EOF
instead of immediately calling shutdown_obj() in order to attempt
flushing the output buffer via write_to_obj().
* server-obj.c (write_obj_data): Added test for unixsock state.
* server-obj.c (write_to_obj): Added test for unixsock state.
When marking obj as being "dead", perform shutdown_obj() instead of
returning -1 and causing obj to be destroyed upon return to mux_io().
* server-logfile.c (open_logfile_obj),
server-process.c (open_process_obj),
server-serial.c (open_serial_obj),
server-telnet.c (connect_telnet_obj),
server-unixsock.c (connect_unixsock_obj):
Reset gotEOF flag when (re)opening console device.
* servers-sock.c (check_console_state): Changed test for unixsock obj
being marked as down.
* server-esc.c (perform_serial_break): Added FIXME for handling
serial-breaks for unixsock objs.
2008-07-16 Chris Dunlap <cdunlap@llnl.gov>
* server-obj.c (format_obj_string): Fixed bug omitting "%D" conversion
specifier for unixsock device name.
2008-07-14 Chris Dunlap <cdunlap@llnl.gov>
* lex.c (lex_create): Added check for null toks.
* server.c (open_daemon_logfile): Fixed double-free() of fp on error.
* log.c (log_err): Fixed bug comparing array against NULL.
* lex.c (validate_sorted_tokens): Added test for null toks.
* server-sock.c (query_consoles_via_regex): Initialized rex to silence
"uninitialized use" warnings when calling regcomp(), even though that
parm is output-only.
* server.c (open_daemon_logfile): Fixed potential resource leak when
error occurs while (re)opening daemon logfile.
* lib/exec/ibm-bc.exp: Added case for when "target bay is empty".
* server-conf.c (process_console): Moved test for is_unixsock_dev() to
the top of the if/else clause to ensure the "unix:" prefix cannot be
misinterpreted.
2008-07-10 Chris Dunlap <cdunlap@llnl.gov>
* conman.spec: Added THANKS to %doc.
* README, conman.spec: Tweaked description.
* THANKS: Added.
* server-telnet.c (connect_telnet_obj): Added errno to socket()
failure error message.
* server-telnet.c (disconnect_telnet_obj): Moved line for state change
to separate it from the new timer being set.
* : Added support for console devices using unix domain sockets.
* server.h: Added unixsock_obj_t and related defs.
* server.c (mux_io): Added unixsock objs to tpoll set.
* server-conf.c (process_console): Updated to create unixsock obj.
* server-conf.c (is_unixsock_dev): Added to parse unixsock console.
* server-logfile.c (create_logfile_obj): Updated for unixsock obj.
* server-logfile.c (get_console_logfile_obj): Updated for unixsock obj.
* server-obj.c (create_obj): Updated assert of valid obj types.
* server-obj.c (destroy_obj): Added unixsock obj destructor.
* server-obj.c (reopen_obj): Added case to reopen unixsock obj.
* server-sock.c (check_console_state): Added check for unixsock obj
to warn client if disconnected and attempt immediate reconnect.
* server-unixsock.c: Added.
* Makefile.in: Added server-unixsock.o.
* man/conman.conf.5.in, etc/conman.conf: Documented "unix:" dev prefix.
2008-01-14 Chris Dunlap <cdunlap@llnl.gov>
* man/conman.1.in: Documented &E client esc char.
* client-tty.c (perform_help_esc): Tweaked verbage for &E help.
* common.c (get_tty_raw): Cleared ECHOCTL.
2008-01-11 Chris Dunlap <cdunlap@llnl.gov>
* client-tty.c (perform_echo_esc): Moved enableEcho toggle outside of
the (get|set)_tty_mode block.
2008-01-10 Chris Dunlap <cdunlap@llnl.gov>
* common.h, common.c, client-tty.c:
Added support for "&E" echoing of client input.
* common.c (get_tty_raw): Changed settings for c_iflag & c_oflag.
* common.c (set_tty_mode): Added FIXME comment.
2008-01-09 Chris Dunlap <cdunlap@llnl.gov>
* : Updated copyright date range.
2007-10-10 Chris Dunlap <cdunlap@llnl.gov>
* DISCLAIMER.LLNS, DISCLAIMER.UC: Updated.
2007-10-08 Chris Dunlap <cdunlap@llnl.gov>
* etc/conman.init.in: Changed default start/stop runlevels.
2007-10-05 Chris Dunlap <cdunlap@llnl.gov>
* : Updated copyright info for LLNS.
2007-09-27 Chris Dunlap <cdunlap@llnl.gov>
* conman.spec: Added tcp_wrappers BuildRequires for mock builds.
2007-09-10 Chris Dunlap <cdunlap@llnl.gov>
* etc/conman.init.in: Fixed bug with SCRIPT_NAME not removing the
leading /[SK][0-9]+/, thereby causing the sysconfig file to be
ignored at boot (when referenced via "/etc/rc5.d/S95conman").
* etc/conman.init.in: Fixed bug with RH_SUBSYS referencing the init
script name instead of the executable daemon name.
2007-07-09 Chris Dunlap <cdunlap@llnl.gov>
* Makefile.in: Fixed bug in SERVER_OBJS3 referencing server-telnet.o.
2007-05-24 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.1.
* META, NEWS: Updated for 0.2.1 release.
2007-05-22 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ibm-bc.exp: Added pattern to handle case where user does not
have authority to set telnet inactivity timeout.
2007-05-19 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/cyclades-ssh.exp, lib/exec/ssh.exp:
Added serial-break comment to interact clause.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp:
Updated user/pswd comment with default password.
* lib/exec/ibm-bc.exp: Consolidated new timeouts in interact clause.
* lib/exec/sun-ilom.exp: Tweaked "session_override" comment. Changed
behavior to prevent theft of console session if "session_override"
is enabled, or exit with an appropriate message otherwise.
2007-05-18 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ibm-bc.exp: Tweaked "session_override" comment.
* lib/exec/ibm-bc.exp: Tweaked "idle_timeout" comment.
2007-05-17 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/ibm-bc.exp, lib/exec/ipmiconsole.exp,
lib/exec/ipmitool.exp, lib/exec/ssh.exp, lib/exec/sun-ilom.exp:
Tweaked "connection established" message.
* lib/exec/ibm-bc.exp, lib/exec/sun-ilom.exp:
Enabled "session_override" by default.
* lib/exec/ibm-bc.exp: Updated comments. Added "bcmm_timeout" to set
the telnet inactivity timeout. Added state var to accept pattern.
Changed checks for unexpected prompts to continue instead of accept.
Changed "idle_timeout" to monitor spawned process instead of user's
keystrokes. Added interact pattern to disable "ESC (" sequence from
stopping console and returning to BCMM.
* lib/exec/ipmiconsole.exp, lib/exec/ipmitool.exp:
Changed checks for duplicate prompts to ignore instead of exit.
* lib/exec/cyclades-ssh.exp, lib/exec/ssh.exp, lib/exec/sun-ilom.exp:
Specified cmdline args to spawned ssh process to use standard port
and disable authentication agent & X11 forwarding.
* lib/exec/sun-ilom.exp: Removed ssh error message exception for
"no version information available".
* lib/exec/sun-ilom.exp: Tweaked regex for disabling "ESC (" action.
2007-05-16 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ipmiconsole.exp, lib/exec/ipmitool.exp:
Added checks for duplicate prompts to generate an error.
* lib/exec/sun-ilom.exp: Removed $connected from the accept state and
timeout clause since the accept state has a known pattern.
* lib/exec/README: Added note about local customizations being lost.
* lib/exec/ipmiconsole.exp, lib/exec/ipmitool.exp: Removed state vars
from the timeout clause that allowed the connection to succeed if
the passwords had already been sent. These vars are not needed here
since the accept state has a known pattern. This also protects
against error messages occasionally getting dropped after an
incorrect password is sent (which previously caused the timeout to
succeed).
* lib/exec/cyclades-ssh.exp: Updated comments. Changed error regex
to match through newline. Added pattern to accept new host key.
* lib/exec/cyclades-telnet.exp: Updated comments. Changed error regex
to match through newline.
* lib/exec/ipmiconsole.exp, lib/exec/ipmitool.exp: Updated comments.
Changed keyg lookup to only happen when pswd is also missing.
Changed error regex to match through newline.
* lib/exec/ssh.exp: Updated comments. Changed error regex to match
through newline. Changed prompt regex for accept state.
Added pattern to accept new host key.
* lib/exec/sun-ilom.exp: Updated comments. Added interact pattern to
disable "ESC (" sequence for stopping console and returning to ILOM.
2007-05-15 Chris Dunlap <cdunlap@llnl.gov>
* README, conman.spec: Tweaked description.
* configure.ac, config.h.in: Moved BROKEN_STDBOOL #ifdef to "bool.h".
* tpoll.c: Added "bool.h" include to replace <stdbool.h>.
* bool.h: Added.
* NEWS: Tweaked notes for 0.2.0.
2007-05-14 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/sun-ilom.exp: Added.
2007-05-02 Chris Dunlap <cdunlap@llnl.gov>
* : Released 0.2.0.
* etc/conman.init.in: Added back Description header (which had been
renamed to Short-Description) in order to comply with chkconfig.
* META, NEWS: Updated for 0.2.0 release.
* configure.ac: Added test for broken <stdbool.h>.
* tpoll.c: Removed <stdbool.h> include in favor of AC's "config.h".
* configure.ac: Reverted previous commit.
* configure.ac: Added _STDC_C99 define to use <stdbool.h> on Solaris.
* server-obj.c (format_obj_string): Cast getpid to int.
* Makefile.in: Added support for datarootdir.
* configure: Updated to autoconf-2.61 (Debian Etch).
* configure.ac, config.h.in: Added <paths.h> header check (Solaris).
* common.h: Wrapped <paths.h> include with test for HAVE_PATHS_H def.
* server.c: Removed <paths.h> include in favor of "common.h" include
which checks for HAVE_PATHS_H.
* server.c (get_sane_env): Set env var TERM=dumb (AIX).
* server-process.c (open_process_obj): Tweaked format of DPRINTF.
* server.c (accept_client): Fixed portability bug by forcing
newly-accept()d client fds to initially use blocking I/O (AIX/BSD).
* util-file.c, util-file.h: Added set_fd_blocking().
* server-conf.c (is_telnet_obj): Fixed bug where port number remained
appended to hostname.
* server-process.c (open_process_obj): Reverted connected info
notification message to use basename.
* etc/conman.init.in (service_init): Re-ordered config cleanup tweaks.
2007-05-01 Chris Dunlap <cdunlap@llnl.gov>
* server-process.c (open_process_obj): Replaced AF_LOCAL with AF_UNIX.
* server-esc.c: Added <arpa/telnet.h> include for use of telnet BREAK.
* server.h: Removed <arpa/telnet.h> include and NTELOPTS redefinition.
* common.h: Added define for _PATH_STDPATH if missing (AIX).
* etc/conman.init.in (log_fini): Moved LSB case into default case.
* etc/conman.init.in (service_status): Terminated output with period.
* etc/conman.init.in (service_status): Added comment.
* etc/conman.init.in: Changed format of usage output.
* etc/conman.init.in (service_status): Changed format of status output.
Added check for "dead" status if process not found & pidfile exists.
2007-04-30 Chris Dunlap <cdunlap@llnl.gov>
* server-conf.c (parse_console_directive): Fixed segfault with
incomplete console directive.
* etc/conman.sysconfig: Reverted re-ordering of CONFIG & DAEMON_ARGS
since DAEMON_ARGS might contain $CONFIG.
* etc/conman.init.in (log_fini): Changed output for default case.
* etc/conman.init.in: Added support for Debian Etch & Ubuntu Edgy.
Updated Required-Start, Required-Stop, Should-Start, Should-Stop.
Renamed OPTIONS to DAEMON_ARGS. Renamed SERVICE_NAME to SCRIPT_NAME.
Redirected ERRMSG to stderr. Forced removal of PIDFILE on stop.
Replaced query_exec() with type. Added log_init() and log_fini().
* etc/conman.sysconfig: Renamed OPTIONS to DAEMON_ARGS.
2007-04-25 Chris Dunlap <cdunlap@llnl.gov>
* lib/conman.exp: Removed executable svn property.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/ibm-bc.exp, lib/exec/ipmiconsole.exp, lib/exec/ipmitool.exp,
lib/exec/ssh.exp: Tweaked documentation.
2007-04-24 Chris Dunlap <cdunlap@llnl.gov>
* etc/conman.conf: Changed keywords in examples to lowercase.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/ibm-bc.exp, lib/exec/ipmiconsole.exp, lib/exec/ipmitool.exp,
lib/exec/ssh.exp: Added support for password database. Restructured.
2007-04-20 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ibm-bc.exp: Tweaked comments.
2007-04-19 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ibm-bc.exp: Renamed "override" to "session_override".
* lib/exec/ibm-bc.exp: Tweaked comments.
* lib/exec/ibm-bc.exp: Added support for "idle_timeout".
* lib/exec/ibm-bc.exp: Added support for "override".
* lib/exec/ibm-bc.exp, lib/exec/ibm-hs20.exp:
Renamed ibm-hs20.exp to ibm-bc.exp.
2007-04-18 Chris Dunlap <cdunlap@llnl.gov>
* server.c (reset_console): Disabled notify_console_objs() taking
place after the actual reset command is executed.
2007-04-17 Chris Dunlap <cdunlap@llnl.gov>
* server.h, server-conf.c: Replaced "execdir" with "execpath".
* server-conf.c (is_telnet_dev, is_serial_dev, is_process_dev,
search_exec_path): Added.
* etc/conman.conf, man/conman.conf.5.in:
Replaced SERVER EXECDIR keyword with SERVER EXECPATH.
* server-process.c (open_process_obj): Changed connected info
notification message to use full pathname to process instead of
basename. Removed warning notification message after exec() failure
since it happens in the child process.
2007-04-05 Chris Dunlap <cdunlap@llnl.gov>
* server.c (main): Added sending SIGTERM to process group ID at exit.
* server.c (begin_daemonize): Changed prototype to return daemonize fd
and pgid via pass-by-reference args.
2007-04-04 Chris Dunlap <cdunlap@llnl.gov>
* conman.spec: Added Requires for expect.
* Makefile.in: Changed install target to use ".new" suffix for
preserving local mods to config files only when the new files differ.
* conman.spec: Tweaked %post, %preun, %postun.
* conman.spec: Changed RPM Group.
* Makefile.in: Changed conman.sysconfig install perms to 0644.
Removed default symbol stripping of conman/conmand executables.
2007-04-03 Chris Dunlap <cdunlap@llnl.gov>
* lib/examples/README, lib/exec/README: Added.
* Makefile.in: Changed 'install' target to install READMEs 0644.
* lib/exec/cyclades-ssh.exp, lib/exec/ssh.exp:
Changed ssh escape char to '&'. This also allows "&B" to fall-thru
and trigger an ssh-generated serial-break.
* lib/exec/cyclades-telnet.exp, lib/exec/ibm-hs20.exp:
Added expect pattern to eat "telnet> send brk" output from "&B".
* lib/exec/cyclades-telnet.exp:
Added support for "&B" to send a serial-break.
* server-obj.c (write_notify_msg):
Fixed bug with potential buffer overrun.
* util-str.c (replace_string):
Fixed bug with potential dereference of freed pointer.
* lib/exec/cyclades-telnet.exp:
Added comment on native telnet support within ConMan.
* lib/exec/ibm-hs20.exp, lib/exec/ipmiconsole.exp,
lib/exec/ipmitool.exp, lib/exec/ssh.exp: Tweaked formatting.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp:
Added support for authtype none.
2007-04-02 Chris Dunlap <cdunlap@llnl.gov>
* server-process.c (open_process_obj): Closed socketpair fds on exec.
* server-conf.c (process_config): Closed config file on exec.
* tpoll.c (tpoll_create): Closed tpoll pipe fds on exec.
* server.c (create_listen_socket, open_daemon_logfile):
Added debugging.
* server-conf.c (process_config): Added debugging.
* server-logfile.c (open_logfile_obj): Tweaked debugging.
* server-obj.c (create_client_obj): Added debugging.
* server-process.c (open_process_obj): Added debugging.
* server-serial.c (open_serial_obj): Added debugging.
* server-telnet.c (open_telnet_obj): Added debugging.
* README, conman.spec: Updated description.
2007-03-30 Chris Dunlap <cdunlap@llnl.gov>
* server.c (main): Sanitized environment variables.
* server.c (get_sane_env): Added from server-process.c.
Added DEBUG to preserve list.
* server.h: Removed get_sane_env() prototype.
* server-process.c (get_sane_env): Removed.
2007-03-29 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/freeipmi.exp, lib/exec/ibm-hs20.exp, lib/exec/ipmitool.exp,
lib/exec/ssh.exp: Updated PATH.
* server-process.c (open_process_obj):
Sanitized environment for exec().
* server-process.c (get_sane_env): Added.
* server.h: Added get_sane_env() prototype.
* etc/conman.conf, man/conman.conf.5.in: Added console dev comment
that "host:port" connections to remote terminal-servers use the
telnet protocol.
2007-03-28 Chris Dunlap <cdunlap@llnl.gov>
* etc/conman.conf: Tweaked comment.
* man/conman.conf.5.in: Added reference to /usr/lib/conman/exec dir.
* lib/exec/ipmiconsole.exp, lib/exec/freeipmi.exp:
Renamed freeipmi.exp to ipmiconsole.exp.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/freeipmi.exp, lib/exec/ibm-hs20.exp, lib/exec/ipmitool.exp,
lib/exec/ssh.exp: Changed error message for failed spawn.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/freeipmi.exp, lib/exec/ibm-hs20.exp, lib/exec/ipmitool.exp,
lib/exec/ssh.exp: Added spawned pid to connection established msg.
* lib/exec/freeipmi.exp, lib/exec/ipmitool.exp: Updated PATH.
* lib/exec/freeipmi.exp, lib/exec/ipmitool.exp: Tweaked comments.
2007-03-27 Chris Dunlap <cdunlap@llnl.gov>
* lib/exec/ipmitool.exp: Removed PATH used for testing.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,
lib/exec/freeipmi.exp, lib/exec/ibm-hs20.exp, lib/exec/ipmitool.exp,
lib/exec/ssh.exp: Tweaked comments.
* lib/exec/freeipmi.exp: Replaced use of ipmiconsole cmdline opt "-k"
with "-K" in order to avoid exposing key on command-line.
* lib/exec/freeipmi.exp: Removed pattern for shell prompt since it is
no longer needed with the SOL-established pattern.
* lib/exec/ipmitool.exp: Added.
* lib/exec/cyclades-ssh.exp, lib/exec/cyclades-telnet.exp,