chore: expose InstructionResult getters in Interpreter result #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Jan 22, 2024
| Return { | ||
| result: InterpreterResult, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Can you revert this? I liked more having structs first than impls
There was a problem hiding this comment.
sure, but I very much dislike this style:
struct A;
struct B;
impl A {}
impl B {}imo this makes it a lot harder to navigate
Closed
makcandrov
reviewed
Jan 22, 2024
Comment on lines
+317
to
+318
| pub const fn is_revert(&self) -> bool { | ||
| self.result.is_ok() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InterpreterResultwraps anInstructionResultThis also exposes the
is_{error,success}functions on theInterpreterResultmoves struct defs around and makes calls const.