Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burntpix criterion bench #1004

Merged
merged 11 commits into from Jan 25, 2024
Merged

Burntpix criterion bench #1004

merged 11 commits into from Jan 25, 2024

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Jan 22, 2024

Related to #986.

Hi @rakita ,

I tried to follow the criterion benches and implement the Burntpix bench from there.

I tried to find the cleanest way to initialise the REVM with empty db from some static genesis allocations, please tell me if you got a better idea :)

Waiting for your feedback !

Thanks a lot!

interface IBURNTPIX {
function run( uint32 seed, uint256 iterations) returns (string);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice touch!

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first iteration! Left nitpicks to clean it up.

@loocapro loocapro marked this pull request as ready for review January 24, 2024 10:50
@loocapro loocapro requested a review from rakita January 24, 2024 11:42
crates/revm/Cargo.toml Outdated Show resolved Hide resolved
@loocapro loocapro requested a review from rakita January 24, 2024 17:39
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rakita rakita merged commit b434308 into bluealloy:main Jan 25, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants