Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set is_optimism to true if default config #1087

Merged
merged 3 commits into from
Feb 14, 2024
Merged

fix: Set is_optimism to true if default config #1087

merged 3 commits into from
Feb 14, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Feb 13, 2024

If optimism_default_handler is enabled by default is_optimism flag will be true

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Valgrind Results:

==4018== Cachegrind, a cache and branch-prediction profiler
==4018== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4018== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4018== Command: target/release/snailtracer
==4018== 
--4018-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==4018== 
==4018== I   refs:      471,787,909
==4018== I1  misses:          6,086
==4018== LLi misses:          2,908
==4018== I1  miss rate:        0.00%
==4018== LLi miss rate:        0.00%
==4018== 
==4018== D   refs:      229,165,034  (152,346,483 rd   + 76,818,551 wr)
==4018== D1  misses:        350,863  (    210,577 rd   +    140,286 wr)
==4018== LLd misses:        137,578  (      4,054 rd   +    133,524 wr)
==4018== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==4018== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4018== 
==4018== LL refs:           356,949  (    216,663 rd   +    140,286 wr)
==4018== LL misses:         140,486  (      6,962 rd   +    133,524 wr)
==4018== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit d6bd010 into main Feb 14, 2024
25 checks passed
This was referenced Feb 14, 2024
@DaniPopes DaniPopes deleted the op_true_default branch March 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant