Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use impl instead of dyn in GetInspector #1157

Merged
merged 2 commits into from Mar 6, 2024

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Mar 5, 2024

Increases minimum Rust version to 1.75

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

the version req bump should be fine imo

@rakita
Copy link
Member

rakita commented Mar 6, 2024

Yep, we are fine with a bump, llvm bug is fixed in v1.75 #887 (comment)

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 8c32fef into bluealloy:main Mar 6, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
@DaniPopes DaniPopes deleted the get-inspector-rpitit branch March 6, 2024 09:01
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* feat: use `impl` instead of `dyn` in `GetInspector`

* chore: clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants