chore: expose functionality for custom EVMs #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Mar 15, 2024
crates/precompile/src/secp256k1.rs
Outdated
| @@ -40,7 +40,7 @@ mod secp256k1 { | |||
|
|
|||
| #[cfg(feature = "secp256k1")] | |||
| #[allow(clippy::module_inception)] | |||
| mod secp256k1 { | |||
| pub mod secp256k1 { | |||
There was a problem hiding this comment.
why do you need this to be public? This mod is made to hide the secp256k1 and k256 inclusion.
ecrecover should be made public
There was a problem hiding this comment.
makes total sense, with these changes 746039d ecrecover is reexported, PTAL
rakita
approved these changes
Mar 16, 2024
Merged
fubuloubu
pushed a commit
to ApeWorX/revm
that referenced
this pull request
Apr 11, 2024
* chore: expose functionality for custom EVMs * reexport ecrecover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to help add custom instructions and precompiles