Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(primitives): kzg intro #1209

Merged
merged 19 commits into from Mar 25, 2024
Merged

docs(primitives): kzg intro #1209

merged 19 commits into from Mar 25, 2024

Conversation

developeruche
Copy link
Contributor

Created documentation for the KZG primitive in the primitive crate

@rakita rakita changed the title Docs Update: KZG primitive docs(primitives): kzg intro Mar 19, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on embedding all the md files in the source code @rakita ?

.DS_Store Outdated Show resolved Hide resolved
@rakita
Copy link
Member

rakita commented Mar 22, 2024

thoughts on embedding all the md files in the source code @rakita ?

Revm book gives a better flow and nicer introduction and explanation, there is no plan to remove it.

@developeruche
Copy link
Contributor Author

thoughts on embedding all the md files in the source code @rakita ?

Revm book gives a better flow and nicer introduction and explanation, there is not plan to remove it.

very true

@rakita
Copy link
Member

rakita commented Mar 22, 2024

@developeruche you didn't remove all of .DS_store files, would recommend adding them to .gitignore after you remove them all

@developeruche
Copy link
Contributor Author

developeruche commented Mar 22, 2024

@developeruche you didn't remove all of .DS_store files, would recommend adding them to .gitignore after you remove them all

Alright, would do that

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rakita rakita merged commit e7363d7 into bluealloy:main Mar 25, 2024
25 checks passed
This was referenced Mar 25, 2024
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* docs: primitive

* docs: KZG primitive

* fixed mistake

* fixed lint error

* fixed book test

* refactor: coinbase to beneficiary

* mod: workspace test

* Revert "refactor: coinbase to beneficiary"

This reverts commit dc89385.

* Revert "fixed book test"

This reverts commit 47062f0.

* revert beneficiary to conbase

* mod: resolved comment

* fixed typo

* del .DS_store

* del .DS_store

* del .DS_store

* mod: update .gitginore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants