Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return specific Return statuses in CALLs #136

Merged
merged 4 commits into from Jun 30, 2022
Merged

Return specific Return statuses in CALLs #136

merged 4 commits into from Jun 30, 2022

Conversation

meetmangukiya
Copy link
Contributor

  • Bubble up the specific Return status of a CALL.
  • Call call_end inspector hook in all terminating paths(a couple missed places).
  • Interpreter run should ignore non-ok CALL statuses

c/f foundry-rs/foundry#1387

@meetmangukiya meetmangukiya marked this pull request as draft June 27, 2022 01:08
@meetmangukiya
Copy link
Contributor Author

Will take a look at test failiures.

@meetmangukiya meetmangukiya mentioned this pull request Jun 28, 2022
Closed
@rakita rakita marked this pull request as ready for review June 30, 2022 20:04
@rakita rakita merged commit 65ce46e into bluealloy:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meetmangukiya @rakita @mattsse