feat: add helpers for working with instruction tables #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
instruction-table-helpers
branch
4 times, most recently
from
24551eb
to
32e2830
Compare
rakita
reviewed
Jun 10, 2024
rakita
reviewed
Jun 10, 2024
rakita
reviewed
Jun 10, 2024
| #[inline] | ||
| pub fn update_boxed_instruction<'a, H, F>(instruction: &mut BoxedInstruction<'a, H>, f: F) | ||
| where | ||
| H: Host + ?Sized + 'a, |
There was a problem hiding this comment.
Yes, I can't really see how to remove it
rakita
reviewed
Jun 10, 2024
DaniPopes
force-pushed
the
instruction-table-helpers
branch
from
32e2830
to
621af86
Compare
Closed
This was referenced Jun 11, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helpers to
InstructionTablesfor inserting and updating instructions into it.No functional changes intended.
Better reviewed with whitespace disabled.