Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eof): fixture 2 tests #1550

Merged
merged 9 commits into from
Jun 20, 2024
Merged

fix(eof): fixture 2 tests #1550

merged 9 commits into from
Jun 20, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jun 19, 2024

  • We are now passing EOF fixture 2 tests.
  • Rename of InvalidFEOpcode to InvalidEFOpcode
  • Fixed bug with aux data extension and setting new data size.
  • Introducing EOFCreateKind in EOFCreateInputs. EOF creation tx data validation is moved inside EOF handler so we can call Inspector before validation is done.
  • EOFCreateOutcome removed and CreateOutcome is used.
  • Refactored EofHeader::size
  • Added soft fail if CREATE/CREATE2 are called with 0xEF00 bytecode.

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Valgrind Results:

==3896== Cachegrind, a cache and branch-prediction profiler
==3896== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3896== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3896== Command: target/release/snailtracer
==3896== 
--3896-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.822952681s
==3896== 
==3896== I   refs:      427,041,235
==3896== I1  misses:          3,239
==3896== LLi misses:          2,798
==3896== I1  miss rate:        0.00%
==3896== LLi miss rate:        0.00%
==3896== 
==3896== D   refs:      204,077,833  (132,269,718 rd   + 71,808,115 wr)
==3896== D1  misses:        341,615  (    201,670 rd   +    139,945 wr)
==3896== LLd misses:        137,735  (      4,449 rd   +    133,286 wr)
==3896== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3896== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3896== 
==3896== LL refs:           344,854  (    204,909 rd   +    139,945 wr)
==3896== LL misses:         140,533  (      7,247 rd   +    133,286 wr)
==3896== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita marked this pull request as ready for review June 20, 2024 12:57
@rakita rakita merged commit 09451cb into main Jun 20, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
@rakita rakita deleted the rakita/eof_fixes branch June 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant