chore(interpreter): use let else
#629
Conversation
| Some(gas_used) => gas!($interp, gas_used), | ||
| None => { | ||
| Some(gas_used) if $interp.gas.record_cost(gas_used) => {} | ||
| _ => { |
There was a problem hiding this comment.
nit any reason to not use the macro
There was a problem hiding this comment.
Would duplicate the assign/return on both branches, doesn't really matter since compiler probably optimizes that anyway
There was a problem hiding this comment.
Can you revert this one, I slightly vary on the fn call side-effect inside if, and second reason is that gas! is used everywhere so it converges to one place
| } | ||
| )* | ||
| ) | ||
| ($interp:expr, $($x:expr),* $(,)?) => ($( |
There was a problem hiding this comment.
this now lets you push multiple values? or what is the new $(,)? for?
There was a problem hiding this comment.
Just allows trailing comma. Sometimes rustfmt will add it and then parsing fails because it is not expected in the macro.
|
It also avoids unwrap, |
* chore(interpreter): use `let else` * use gas macro
* chore(interpreter): use `let else` * use gas macro
Split off from #582
And macros style changes.
Improves readability. MSRV for this feature is 1.65 but I see it's already present in
revm.