Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(inspector): add value parameter to Inspector::selfdestruct #645

Merged
merged 1 commit into from
Aug 25, 2023
Merged

refactor(inspector): add value parameter to Inspector::selfdestruct #645

merged 1 commit into from
Aug 25, 2023

Conversation

tonyke-bot
Copy link
Contributor

Add value:U256 as the third parameter to Inspector::selfdestruct per discussion in #638.

Thus, the function signature changes from

fn selfdestruct(&mut self, _contract: B160, _target: B160) {}

to

fn selfdestruct(&mut self, _contract: B160, _target: B160, _value: U256) {}

@tonyke-bot tonyke-bot changed the title add value parameter to Inspector::selfdestruct refactor(inspector): add value parameter to Inspector::selfdestruct Aug 24, 2023
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rakita rakita merged commit ff5a2bc into bluealloy:main Aug 25, 2023
7 checks passed
mikelodder7 pushed a commit to LIT-Protocol/revm that referenced this pull request Sep 12, 2023
Evalir pushed a commit to Evalir/revm that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants