Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state): Make Bundle extend wipe aware #655

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

rakita
Copy link
Member

@rakita rakita commented Aug 28, 2023

Previously this was not the case and updating storage every time was a bug.

If both this and other bundle are presents. We iterate over other reverts to find if it has wipe flag, if it is true, we take the bundle state of this and expand revert with this state (If there are slots missing).

We nullify other wipe flag if this wipe flag is present.

And replace the state if other wipe flag is present, else we just extend this plain state.

@rakita rakita force-pushed the rakite/bundle_extend_wipe_aware branch from 7488869 to b836355 Compare August 28, 2023 13:52
@rakita rakita merged commit 98a4a18 into main Aug 28, 2023
7 checks passed
@rakita rakita deleted the rakite/bundle_extend_wipe_aware branch September 5, 2023 17:24
mikelodder7 pushed a commit to LIT-Protocol/revm that referenced this pull request Sep 12, 2023
* Make Bundle extend wipe aware

* move revert extend when both are present
Evalir pushed a commit to Evalir/revm that referenced this pull request Sep 14, 2023
* Make Bundle extend wipe aware

* move revert extend when both are present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant