EIP-6780: SELFDESTRUCT only in same transaction #719
Conversation
thedevbirb
force-pushed
the
eip-6780
branch
from
00f3946
to
8e1344b
Compare
|
Didn't forget about this, checking things related to Verkle tree. |
| // touch target account | ||
|
|
||
| let acc = if address != target { | ||
| let [acc, target_account] = self.state.get_many_mut([&address, &target]).unwrap(); |
There was a problem hiding this comment.
get_many_mut is still nightly feature: https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.get_many_mut
There was a problem hiding this comment.
Oh forget this, Hashbrown has it
crates/revm/src/journaled_state.rs
Outdated
| }); | ||
| } | ||
| } else { | ||
| Self::touch_account(self.journal.last_mut().unwrap(), &address, acc); |
There was a problem hiding this comment.
This line is not needed, address is considered touched as this is the account that we are currently executing.
thedevbirb
force-pushed
the
eip-6780
branch
from
96b3565
to
4e08ba6
Compare
|
I should have resolved all your comments, thanks for the support. I'm happy to see that tests are passing, even if in local they were failing for some reason.. |
Tests were failing for some other reason, found the problem and merged in on |
Closes #524. Reading the EIP, when the contract is not created in the same tx,
SELFDESTRUCTsimply becomes a transfer, while keeping the gas cost of the opcode. As such, I tried to modify only theJournaledStateto reflect that.