EIP-7516: BLOBBASEFEE opcode #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for on possible naming change: https://github.com/ethereum/go-ethereum/pull/28098/files#r1327222175 |
DaniPopes
approved these changes
Sep 15, 2023
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Rjected
approved these changes
Sep 15, 2023
crates/primitives/src/env.rs
Outdated
Comment on lines
79
to
83
| /// Takes `blob_excess_gas` saves it inside env | ||
| /// and calculates `blob_fee` with [`BlobGasAndFee`]. | ||
| pub fn set_blob_gas_and_fee(&mut self, excess_blob_gas: u64) { | ||
| self.blob_gas_and_fee = Some(BlobGasAndFee::new(excess_blob_gas)); | ||
| } |
There was a problem hiding this comment.
I like this, makes it very easy to set both when initializing the env
| @@ -264,7 +265,7 @@ pub const OPCODE_JUMPMAP: [Option<&'static str>; 256] = [ | |||
| /* 0x47 */ Some("SELFBALANCE"), | |||
| /* 0x48 */ Some("BASEFEE"), | |||
| /* 0x49 */ Some("BLOBHASH"), | |||
| /* 0x4a */ None, | |||
| /* 0x4a */ Some("BLOBFEE"), | |||
There was a problem hiding this comment.
does it matter that the opcode is called BLOBBASEFEE in the spec here?
There was a problem hiding this comment.
This: #721 (comment)
I like BLOBFEE more :)
There was a problem hiding this comment.
ah I missed that, yeah I like BLOBFEE more too
There was a problem hiding this comment.
Renamed back to BLOBBASEFEE per Eth R&D discussion
|
@Rjected can you review, had some small (name) changes, it is ready to be merged |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancun: https://eips.ethereum.org/EIPS/eip-7516
add Blobfee opcode