Document when InvalidTransaction errors are thrown #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is correct it should be |
rakita
approved these changes
Sep 20, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #594
I added some docs to the
InvalidTransactionenum.I just excluded 3 variants because their meaning are obvious:
NonceTooHighNonceTooLowInvalidChainIdI also renamed the first variant:
PriorityFeeGreaterThanMaxFeethat previously wasGasMaxFeeGreaterThanPriorityFee.I think it's better named like this as that error arises when the
priority_feeis actually greater than themax_feeand not the contrary.Let me know WDYT!