Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eip4844): Pass eth tests, additional conditions added. #735

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

rakita
Copy link
Member

@rakita rakita commented Sep 20, 2023

Added failing condition to Env, now we pass all tests related to blobs

@rakita rakita changed the title fix(eip4844): Pass eth tests, add condition to env. fix(eip4844): Pass eth tests, additional conditions added. Sep 20, 2023
Copy link
Collaborator

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the suggestions

crates/primitives/src/env.rs Outdated Show resolved Hide resolved
crates/primitives/src/result.rs Show resolved Hide resolved
crates/primitives/src/env.rs Show resolved Hide resolved
@rakita rakita merged commit cb39117 into main Sep 20, 2023
8 checks passed
@rakita rakita deleted the eip4844_pass_eth_tests branch September 21, 2023 23:47
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants