Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derive more traits #745

Merged
merged 9 commits into from
Oct 11, 2023
Merged

feat: derive more traits #745

merged 9 commits into from
Oct 11, 2023

Conversation

DaniPopes
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

some derives like hash may not be needed but can't hurt

crates/revm/src/evm_impl.rs Outdated Show resolved Hide resolved
DaniPopes and others added 3 commits September 29, 2023 20:38
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@@ -6,10 +6,10 @@ use alloc::vec::Vec;
use core::fmt;

/// The EVM stack limit, in number of items.
pub const STACK_LIMIT: usize = 1024;
const STACK_LIMIT: usize = 1024;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave it as a pub, it does not hurt

#![cfg_attr(not(feature = "std"), no_std)]
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@@ -34,7 +35,7 @@ pub struct State<DB: Database> {
/// return not existing account and storage.
///
/// Note: It is marked as Send so database can be shared between threads.
pub database: DB, //Box<dyn Database<Error = DBError> + Send + 'a>,
pub database: DB,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@rakita
Copy link
Member

rakita commented Oct 11, 2023

@DaniPopes if you are okay, would take this over

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 7a99f16 into bluealloy:main Oct 11, 2023
8 checks passed
@DaniPopes DaniPopes deleted the debugs branch October 17, 2023 09:48
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants