Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primitives): Use Upstream Alloy Create Implementations #775

Merged
merged 1 commit into from Oct 6, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Oct 6, 2023

Description

Since create and create2_address are used internally and external implementations can just use the methods directly on the re-exported Address type, this PR removes the utility methods and inlines the upstream alloy creation function calls.

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was left there to not have a lot of breaking changed in 3.5. Fine to remove it now!

@rakita rakita merged commit 023be42 into bluealloy:main Oct 6, 2023
8 checks passed
@refcell refcell deleted the refcell/create-refactor branch October 6, 2023 20:07
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants