Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fix): cleaned example command for running tests #810

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

tikhoplav
Copy link
Contributor

The command posted at the front page of the documentation
currently is not executable as is, it contains trailing spaces at the first line, which causes script to fail:

$ cargo run --profile ethtests -p revme -- \                                           
statetest \
../ethtests/GeneralStateTests/ \
../ethtests/LegacyTests/Constantinople/GeneralStateTests/ \
bins/revme/tests/EIPTests/StateTests/stEIP5656-MCOPY/ \
bins/revme/tests/EIPTests/StateTests/stEIP1153-transientStorage/
    Finished ethtests [optimized + debuginfo] target(s) in 0.13s
     Running `target/ethtests/revme ' '`
error: The subcommand ' ' wasn't recognized

USAGE:
	revme help <subcommands>...

For more information try --help
statetest: command not found

After this minor fix:

$ cargo run --profile ethtests -p revme -- \
    statetest \
    ../ethtests/GeneralStateTests/ \
    ../ethtests/LegacyTests/Constantinople/GeneralStateTests/ \
    bins/revme/tests/EIPTests/StateTests/stEIP5656-MCOPY/ \
    bins/revme/tests/EIPTests/StateTests/stEIP1153-transientStorage/
    Finished ethtests [optimized + debuginfo] target(s) in 0.12s
     Running `target/ethtests/revme statetest ../ethtests/GeneralStateTests/ ../ethtests/LegacyTests/Constantinople/GeneralStateTests/ bins/revme/tests/EIPTests/StateTests/stEIP5656-MCOPY/ bins/revme/tests/EIPTests/StateTests/stEIP1153-transientStorage/`

Running tests in ../ethtests/GeneralStateTests/...
██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 2621/2621Finished execution. Total CPU time: 22.385226s
All tests passed!

Running tests in ../ethtests/LegacyTests/Constantinople/GeneralStateTests/...
████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 0/0Finished execution. Total CPU time: 0.000000s
All tests passed!

Running tests in bins/revme/tests/EIPTests/StateTests/stEIP5656-MCOPY/...
████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 0/0Finished execution. Total CPU time: 0.000000s
All tests passed!

Running tests in bins/revme/tests/EIPTests/StateTests/stEIP1153-transientStorage/...
████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 0/0Finished execution. Total CPU time: 0.000000s
All tests passed!

@rakita rakita merged commit 1dcebc4 into bluealloy:main Oct 18, 2023
8 checks passed
@rakita
Copy link
Member

rakita commented Oct 18, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants