Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(primitives): Add docs to optimism InvalidTransaction errors. #884

Merged
merged 1 commit into from Nov 27, 2023

Conversation

clabby
Copy link
Contributor

@clabby clabby commented Nov 26, 2023

Overview

Adds short-term documentation to the optimism variants of the InvalidTransaction error, which are bubbled up into Halt::FailedDeposit by the optimism handlers in the revm crate, requested in #883.

If requested, we can follow this up with a reimagined handling of these special cases to reduce ambiguity in the failed deposit path.

Resources for reviewers

@rakita rakita merged commit 32e0edf into bluealloy:main Nov 27, 2023
8 checks passed
@clabby clabby deleted the cl/doc-op-errors branch November 27, 2023 16:16
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants