feat(ethersdb): basic_ref return none instead of panic #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkr8os
force-pushed
the
ethersdb-error-handling
branch
from
1a9ed19
to
074740f
Compare
|
Silently failing is maybe even worse, as you would just get the wrong result and people wouldn't know if it is revm or connection. The solution would be to propagate the error and set |
0xkr8os
force-pushed
the
ethersdb-error-handling
branch
from
1e26b73
to
e629393
Compare
0xkr8os
force-pushed
the
ethersdb-error-handling
branch
from
e629393
to
8ef70b0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of panicking whenever there's an error fetching the account data, return None. This behavior is similar to the EmptyDB and helpful in unit tests when using the mock provider. The tradeoff here is that any RPC client connection issues can surface as EVM execution revert errors but these can be easily mitigated earlier on in the middleware setup process. If the client connection is established, the behavior is essentially the same for callers.