Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Inspector) add CallOutcome to call/call_end #985

Merged
merged 54 commits into from
Jan 18, 2024

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Jan 17, 2024

Related to #872

Added wrapper type on Inspector.call, refactored a bit the interpreter call_outcome function.

@rakita feel free to point any other place where I could contribute a bit!

Thanks a lot!

@rakita rakita changed the title Improve/inspector call refactor(Inspector) add CallOutcome to call/call_end Jan 17, 2024
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comments are a little bit verbose but it is fine.

@rakita rakita merged commit 70ab8b6 into bluealloy:main Jan 18, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants