-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Molecule test for display tunning and dns client #175
Molecule test for display tunning and dns client #175
Conversation
strus38
commented
Apr 14, 2020
- Added molecule test in display_tuning.
- Added molecule test in dns_client - warning the testing is limited to linters since /etc/resolv.conf cannot be touched within a container.
… since /etc/resolv.conf cannot be updated within a container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Added a few comments.
I still need to check the issue with dns_client/converge/resolv.conf before final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to run the dns_client role during converge within docker:
$ podman exec -it instance cat /etc/resolv.conf
#### Blue Banquise file ####
## Ansible managed: Do NOT edit this file manually!
search .localhost
nameserver 10.10.0.1
To achieve this, umount the bind mounted /etc/resolv.conf in the prepare phase:
---
- name: Prepare
hosts: all
tasks:
- name: "Umount Docker's /etc/resolv.conf"
mount:
path: /etc/resolv.conf
state: unmounted
All fixed. IT works like a charm now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me.