Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule test for display tunning and dns client #175

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Molecule test for display tunning and dns client #175

merged 4 commits into from
Apr 15, 2020

Conversation

strus38
Copy link
Contributor

@strus38 strus38 commented Apr 14, 2020

  • Added molecule test in display_tuning.
  • Added molecule test in dns_client - warning the testing is limited to linters since /etc/resolv.conf cannot be touched within a container.

@btravouillon btravouillon self-requested a review April 14, 2020 16:26
Copy link
Member

@btravouillon btravouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Added a few comments.
I still need to check the issue with dns_client/converge/resolv.conf before final review.

roles/core/display_tuning/molecule/default/molecule.yml Outdated Show resolved Hide resolved
roles/core/display_tuning/molecule/default/prepare.yml Outdated Show resolved Hide resolved
roles/core/display_tuning/molecule/default/converge.yml Outdated Show resolved Hide resolved
roles/core/dns_client/molecule/default/molecule.yml Outdated Show resolved Hide resolved
Copy link
Member

@btravouillon btravouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to run the dns_client role during converge within docker:

$ podman exec -it instance cat /etc/resolv.conf
#### Blue Banquise file ####
## Ansible managed: Do NOT edit this file manually!

search .localhost
nameserver 10.10.0.1 

To achieve this, umount the bind mounted /etc/resolv.conf in the prepare phase:

---
- name: Prepare
  hosts: all

  tasks: 
    - name: "Umount Docker's /etc/resolv.conf"
      mount:
        path: /etc/resolv.conf
        state: unmounted

@strus38 strus38 requested a review from oxedions as a code owner April 14, 2020 19:33
@strus38
Copy link
Contributor Author

strus38 commented Apr 14, 2020

All fixed. IT works like a charm now.

Copy link
Member

@btravouillon btravouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks!

Copy link
Member

@oxedions oxedions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.

@oxedions oxedions merged commit b89fad5 into bluebanquise:master Apr 15, 2020
@strus38 strus38 deleted the feature/display_tunning-dns_client branch April 19, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants