Add unitary molecule tests for dhcp_server role

[osmocl]

• Assing static ip in docker containers
• Using a fake host declared in molecule.yml
• Run unitary tests

[btravouillon]

Hi @osmocl ,
Thank you for this new test! A few comments inline.

[osmocl]

In my platform the check E301 for ansible-lint is working perfectly in skip_list and warn_list.
I dot not know why it is not working here.

[btravouillon]

In my platform the check E301 for ansible-lint is working perfectly in skip_list and warn_list.
I dot not know why it is not working here.

ansible-lint runs at the root of the project, it won't look at roles/core/dhcp_server/.ansible-lint.

This is the same failure than in #412, with the same command. You can safely add changed_when: False.

[hmeScaler]

Hello,
I just remembered that the python module python3-netaddr.noarch will be required to be able to calculate the DHCP server configuration files.
Can we add this verification here?
Normally it's the bluebanquise role molecule test that does this verification.

bluebanquise/roles/core/bluebanquise/molecule/default/verify.yml

Line 7 in be64686

- name: Test ipaddr filter in molecule controller

It is smart to re-check here?
Regards

[btravouillon]

I just remembered that the python module python3-netaddr.noarch will be required to be able to calculate the DHCP server configuration files.
Can we add this verification here?

This module is required on the ansible controller, not the dhcp server. It is explicitly installed here for this scenario, there is no need to verify it on the ansible controller.

[hmeScaler]

I just remembered that the python module python3-netaddr.noarch will be required to be able to calculate the DHCP server configuration files.
Can we add this verification here?

This module is required on the ansible controller, not the dhcp server. It is explicitly installed here for this scenario, there is no need to verify it on the ansible controller.

Great,
That's what I wanted to know,
Thanks @btravouillon

[btravouillon]

Looks good to me. 👍
Thank you @osmocl.

[oxedions]

Dear @osmocl
Could you also increment role version, like you did here for nfs_server:

https://github.com/bluebanquise/bluebanquise/pull/412/files

[btravouillon]

Could you also increment role version, like you did here for nfs_server:

Well, I explicitly asked him to remove it. There is no functional change in the role, only a new molecule scenario.

[oxedions]

Could you also increment role version, like you did here for nfs_server:

Well, I explicitly asked him to remove it. There is no functional change in the role, only a new molecule scenario.

OK. Since it was incremented for the nfs_server, I was wondering. Let's keep it like this.

[btravouillon]

Could you also increment role version, like you did here for nfs_server:

Well, I explicitly asked him to remove it. There is no functional change in the role, only a new molecule scenario.

OK. Since it was incremented for the nfs_server, I was wondering. Let's keep it like this.

That's a mistake. nfs_client introduced a new variable, not nfs_server.