Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding molecule unitary tests for advanced_dhcp_server role #428

Merged
merged 3 commits into from
Nov 8, 2020
Merged

Adding molecule unitary tests for advanced_dhcp_server role #428

merged 3 commits into from
Nov 8, 2020

Conversation

osmocl
Copy link
Contributor

@osmocl osmocl commented Oct 20, 2020 •
edited

Molecule tests for advanced_dhcp_server role.

  • Test shared networks feature in dhcp
  • Check compute with mac address
  • Check (opt61 and opt82) in dhcp configuration.
  • Check dhcp syntax with dhcpd -t -cf /etc/dhcp/dhcpd.conf
  • Check dhcpd service is enabled

@osmocl osmocl mentioned this pull request Oct 20, 2020
Closed
34 tasks
btravouillon
btravouillon approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@btravouillon btravouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@oxedions
Copy link
Member

oxedions commented Nov 8, 2020

Dear @osmocl
Thanks a lot for this PR.
Merging.

@oxedions oxedions merged commit 0cddb7e into master Nov 8, 2020
@btravouillon btravouillon deleted the osmocl/molecule_tests_advanced_dhcp_server branch November 8, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btravouillon btravouillon btravouillon approved these changes

@oxedions oxedions Awaiting requested review from oxedions oxedions is a code owner

@bouriquet bouriquet Awaiting requested review from bouriquet

@johnnykeats johnnykeats Awaiting requested review from johnnykeats johnnykeats is a code owner

@hmeScaler hmeScaler Awaiting requested review from hmeScaler

Assignees
No one assigned
Labels
ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@osmocl @oxedions @btravouillon