Conman : Improve molecule tests #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmocl
requested review from
btravouillon,
oxedions,
bouriquet,
johnnykeats and
hmeScaler
|
@oxedions Did you build conman for el7 on purpose? Should it replace the package from the OS? I would rather prefer to keep the conman from upstream. |
34 tasks
|
@btravouillon No, it is a mistake. I did it too fast. Conman should not be provided on BB repositories on EL7. I will remove it. |
btravouillon
suggested changes
Nov 8, 2020
|
@oxedions, as discussed please do not forget to remove this package : Thanks in advance ! |
osmocl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding molecule tests for conman role.