Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup molecule test for nic #512

Closed
wants to merge 2 commits into from

Conversation

btravouillon
Copy link
Member

Add molecule tests for role nic.
Add the tag molecule-notest to the modprobe tasks to avoid issues in the Docker containers. These modules are not required to test the role.

One test fails with ip4_multi using the example from the readme:

          - interface: multi0
            ip4_multi:
              - 172.16.0.2/16
              - 172.16.0.3/16
              - 192.168.1.117/24

Ansible skips the template task Set NIC configuration when ip4 is not defined, thus this interface is not configured. This might be a bug in the task, or an error in the documentation. @oxedions @johnnykeats please tell me if you need me to fix the task or the documentation.

I also fixed a condition where vlan was not considered as a boolean in task Load VLAN module if needed. (task was not skipped with vlan: False)

@btravouillon btravouillon added needs-backport Need to backport this to stable branch ci/cd labels Dec 20, 2020
@btravouillon btravouillon marked this pull request as draft December 20, 2020 07:44
@oxedions oxedions closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd needs-backport Need to backport this to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants