Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add molecule tests for role
nic
.Add the tag
molecule-notest
to the modprobe tasks to avoid issues in the Docker containers. These modules are not required to test the role.One test fails with
ip4_multi
using the example from the readme:Ansible skips the template task Set NIC configuration when
ip4
is not defined, thus this interface is not configured. This might be a bug in the task, or an error in the documentation. @oxedions @johnnykeats please tell me if you need me to fix the task or the documentation.I also fixed a condition where
vlan
was not considered as a boolean in task Load VLAN module if needed. (task was not skipped withvlan: False
)