Merge pull request python-qt-tools#103 from altendky/pyqtBoundSignal_…

…disconnect_optional `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional
bluebird75 · Oct 4, 2020 · 4dc81d3 · 4dc81d3
2 parents 9b5e9e4 + 4f1f73f
commit 4dc81d3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 * [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str`
 
 ### Changed
+* [#103](https://github.com/stlehmann/PyQt5-stubs/pull/103) `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional
 * [#100](https://github.com/stlehmann/PyQt5-stubs/pull/100) fill generic parameter as `sip.array[int]` for QtDataVisualization textures
 * [#92](https://github.com/stlehmann/PyQt5-stubs/pull/92) remove self from `qDefaultSurfaceFormat()` and `qIdForNode()`
 * [#83](https://github.com/stlehmann/PyQt5-stubs/pull/83) fixes `sip.array` to be generic

diff --git a/PyQt5-stubs/QtCore.pyi b/PyQt5-stubs/QtCore.pyi
@@ -35,7 +35,10 @@ class pyqtBoundSignal:
 
     def emit(self, *args: typing.Any) -> None: ...
     def connect(self, slot: "PYQT_SLOT") -> "QMetaObject.Connection": ...
-    def disconnect(self, slot: typing.Union["PYQT_SLOT", "QMetaObject.Connection"]=None) -> None: ...
+    @typing.overload
+    def disconnect(self) -> None: ...
+    @typing.overload
+    def disconnect(self, slot: typing.Union["PYQT_SLOT", "QMetaObject.Connection"]) -> None: ...
 
 
 class pyqtSignal: