Some minor changes and fixups #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
n1tehawk
commented
Oct 21, 2016
n1tehawk
commented
- be clearer on M.EPSILON
- whitespace and code formatting
- remove some unnecessary code from _is_table_equals()
- update AppVeyor to use Lua 5.3.3
Also: - Set it to the actual machine epsilon, not twice the value. (i.e.: be more strict/picky on rounding errors in almostEquals) - Move EPSILON to top of file, make clear it's now a configuration var (user may assign to M.EPSILON)
|
Somehow github's CI integration hooks didn't pick up on this PR. I'll try to force-push my branch to get it to 'catch up' again... |
n1tehawk
force-pushed
the
contrib
branch
2 times, most recently
from
376c181
to
743f82e
Compare
Coverage analysis indicates that the test for an "empty" actualKeysMatched table always succeeds, and the enclosed return statement never gets executed. This is to be expected, as for any given (non table-type) key `k` that is present in `actual` but not in `expected`, our earlier value-based test would already fail. We compare actual[k] against (expected[k] == nil), which won't pass. Fixed this by removing the unnecessary code.
|
The commit is fine, I will accept it. However, after re-reading the discussion with Laurent, I think he makes a good point that luaunit should not introduce a bias in the calculation. marginBoost should go away... I'll discuss it further in #68 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.