Better list diffing2 #79

bluebird75 · 2016-11-10T20:45:56Z

Cleaned up version of the list diff analysis

# Conflicts: # luaunit.lua

n1tehawk · 2016-11-10T23:00:02Z

run_functional_tests.lua

            -- line = line:sub(1,idxStart-1)..source..line:sub(idxEnd+1)
            -- string.gsub( line, dest, source )
            if verbose then
-                print('Result: '..line )
+                print('Result        : '..line )


That whitespace looks weird, is it really supposed to be there?

Ah, I got it. It brings the line's prefix up to the same length as 'Modifying line: ' further up, for aligment / easier comparison.

n1tehawk · 2016-11-10T23:03:38Z

luaunit.lua

@@ -1036,6 +1029,7 @@ local function _is_table_equals(actual, expected, recursions)
    return true
 end
 M.private._is_table_equals = _is_table_equals
+local is_equals = _is_table_equals


I'd prefer singular here in the function name, i.e. is_equal.

bluebird75 · 2016-11-11T20:46:04Z

When I use a local, it does not work. I get the following error message :

d:\work\luaunit\luaunit-git\luaunit2>lua run_unit_tests.lua
is_equalsfunction: 0083B6F8`
.....................................................................................is_equalsnil
F....................................is_equalsnil
E......................is_equalsnil
E...
Failed tests:

1) TestLuaUnitErrorMsg.test_printTableWithRef

.\test\test_luaunit.lua:1937: Error message does not contain: "lists <table: "

Error message received: ".\luaunit.lua:661: attempt to call global 'is_equals' (a nil value)"


stack traceback:
    .\test\test_luaunit.lua:1937: in function 'TestLuaUnitErrorMsg.test_printTableWithRef'


2) TestLuaUnitUtilities.test_diffAnalysisThreshold

.\luaunit.lua:661: attempt to call global 'is_equals' (a nil value)

stack traceback:
    .\test\test_luaunit.lua:253: in function 'TestLuaUnitUtilities.test_diffAnalysisThreshold'


3) TestLuaUnitUtilities.test_suitableForMismatchFormatting

.\luaunit.lua:661: attempt to call global 'is_equals' (a nil value)

stack traceback:
    .\test\test_luaunit.lua:246: in function 'TestLuaUnitUtilities.test_suitableForMismatchFormatting'


Ran 149 tests in 0.024 seconds, 146 successes, 1 failure, 2 errors

The spurious prints qre because I added the extra lines to debug the situation :

lines 658-661 :

i = 1
print( 'is_equals'..tostring(is_equals ) )
while i <= longest do
     if not is_equals(ta[i], tb[i]) then

This is the is_equals which triggers the error.

lines 1044-1047 :

M.private._is_table_equals = _is_table_equals
local is_equals = _is_table_equals
print( 'is_equals'..tostring(is_equals ) )

bluebird75 · 2016-11-11T21:02:28Z

The build fails because lua does not have the same representation of numbers on windows and linux...

Annoying for test based on textual representations :-)

n1tehawk · 2016-11-11T21:02:58Z

Okay, I now see where the problem lies: Since your new routines are further up in the source code, this is a case of "use before declare" - leading to those errors.

There are two possible solutions: Either a) move the entire _is_table_equals() block/logic further up (or your list formatting further down); or b) declare something like

local is_equals -- alias for _is_table_equals() function, gets assigned below

near the top of the file (e.g. under "general utility functions"), and then do a simple is_equals = _is_table_equals after the function has been declared.

Regards, NiteHawk

n1tehawk · 2016-11-12T20:46:34Z

The build fails because lua does not have the same representation of numbers on windows and linux...

We have encountered and worked around number formatting issues before, e.g. test/test_luaunit.lua#L1671-L1675.

Maybe this would be a good opportunity to tackle the problem at the prettystr() level, eliminating the differences between Lua versions?

n1tehawk · 2016-11-12T21:05:51Z

n1tehawk@e0d1d18 illustrates what I have in mind...

…t when the alternate form "1.#INF" is used.

…n lua compiled with integer as a single precision float (as opposed to default double precision)

# Conflicts: # .luacheckrc

…al default already takes care of it

coveralls · 2016-11-12T22:14:50Z

Coverage decreased (-4.3%) to 95.514% when pulling 5149065 on better-list-diffing2 into d1a9ddc on master.

bluebird75 · 2016-11-13T20:03:01Z

That's actually a good idea ! We can do it after merging in this branch.

You want to take care of it ?

Apart from that, any further comments on this branch ?

coveralls · 2016-11-13T20:12:14Z

Coverage increased (+0.01%) to 99.838% when pulling f304be6 on better-list-diffing2 into d1a9ddc on master.

n1tehawk · 2016-11-13T20:18:11Z

That's actually a good idea ! We can do it after merging in this branch.
You want to take care of it ?

Sure, I can do that.

Apart from that, any further comments on this branch ?

Not really. I've noted a few smaller things here and there, but it's a bit hard to keep track of this PR in its entirety (as it needs some rebasing onto the current master by now). I think you should merge it first, if specific issues come up after that, we can still improve on / fix them later.

If a more general luacheck is giving you troubles (makes you struggle with Lua syntax), I'll gladly help with that too.

Regards, NiteHawk

bluebird75 added 6 commits November 9, 2016 21:31

Rename string_sub to string_gsub

8a8dd88

Implement improved list difference analysis

5fbd4c6

No need to add new function for equality comparison

e4b54c0

Merge branch 'master' into better-list-diffing2

3b357ec

# Conflicts: # luaunit.lua

Fix functional and unit-tests

9d35433

Use private function, not working with local function

e561510

bluebird75 mentioned this pull request Nov 10, 2016

Better list diffing #78

Closed

bluebird75 added 3 commits November 10, 2016 21:53

Merge branch 'master' into better-list-diffing2

c1b8e18

# Conflicts: # luaunit.lua

Avoid values where lua 5.2 and 5.3 differ

e612a73

Adjust representation of inf for lua 5.3 and add guards for lua 5.3

177659e

n1tehawk reviewed Nov 10, 2016

View reviewed changes

bluebird75 added 7 commits November 12, 2016 22:07

Rename is_equals to is_equal and define it as a local function

aeab493

Rename variables for more readability

aec57a2

Avoid luacheck warning

e32387d

Use the canonical form "inf" for reference text file and adjust outpu…

14095c7

…t when the alternate form "1.#INF" is used.

Use smaller number to avoid triggering printing with exponentiation o…

9c9e3d7

…n lua compiled with integer as a single precision float (as opposed to default double precision)

Merge branch 'master' into better-list-diffing2

bd87745

# Conflicts: # .luacheckrc

No longer need to explicitly ignore test names file by file, the glob…

5149065

…al default already takes care of it

Disable unused code to keep code coverage high

f304be6

bluebird75 merged commit 41927da into master Nov 18, 2016

bluebird75 deleted the better-list-diffing2 branch November 18, 2016 16:48

n1tehawk mentioned this pull request Nov 18, 2016

Some fixes, uniform prettystr() output for numbers #81

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better list diffing2 #79

Better list diffing2 #79

bluebird75 commented Nov 10, 2016

n1tehawk Nov 10, 2016

n1tehawk Nov 10, 2016

n1tehawk Nov 10, 2016

bluebird75 Nov 11, 2016

bluebird75 commented Nov 11, 2016

bluebird75 commented Nov 11, 2016

n1tehawk commented Nov 11, 2016

n1tehawk commented Nov 12, 2016

n1tehawk commented Nov 12, 2016

coveralls commented Nov 12, 2016 •

edited

bluebird75 commented Nov 13, 2016

coveralls commented Nov 13, 2016 •

edited

n1tehawk commented Nov 13, 2016

Better list diffing2 #79

Better list diffing2 #79

Conversation

bluebird75 commented Nov 10, 2016

n1tehawk Nov 10, 2016

Choose a reason for hiding this comment

n1tehawk Nov 10, 2016

Choose a reason for hiding this comment

n1tehawk Nov 10, 2016

Choose a reason for hiding this comment

bluebird75 Nov 11, 2016

Choose a reason for hiding this comment

bluebird75 commented Nov 11, 2016

bluebird75 commented Nov 11, 2016

n1tehawk commented Nov 11, 2016

n1tehawk commented Nov 12, 2016

n1tehawk commented Nov 12, 2016

coveralls commented Nov 12, 2016 • edited

bluebird75 commented Nov 13, 2016

coveralls commented Nov 13, 2016 • edited

n1tehawk commented Nov 13, 2016

coveralls commented Nov 12, 2016 •

edited

coveralls commented Nov 13, 2016 •

edited