forked from chromium/chromium
-
-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Safe Browsing] Abstract signin dep from RealTimeUrlLookupService
This CL continues with the abstraction of dependencies on signin and sync from //components/safe_browsing's access token fetching flow in order to enable reuse by WebLayer. The concrete step taken here is to abstract the dependencies on //components/safe_browsing/core/browser/sync from RealTimeUrlLookupService, passing these dependencies in via the constructor. There are no behavioral changes in this CL: - //chrome and //ios/chrome's factories glue the relevant parameters from //components/safe_browsing/core/browser/sync - //weblayer's factory passes in values for the parameters such that access token fetching for URL lookups continues to be disabled in WebLayer Followup work will bring up support for access token fetching in WebLayer. Bug: 1080748 Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842942}
- Loading branch information
1 parent
4b932f7
commit 85753b0
Showing
13 changed files
with
117 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.