-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media playback not working on latest build... #38
Comments
Hi, thank you for the reporting! Due to the deployment of
No, do not report problems occurred by using chromium-legacy to the Chromium development team even if the problem seems to be caused by the original CL/source. |
Fixed at r943791. |
Thx..... |
Change-Id: I6b786ef9df2f5353bb2dd62cf2bdaf761febf721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216198 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4664@{#38} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
We need to determine whether changing these tasks to have USER_BLOCKING priority was the cause of a regression in startup performance on Android that we are observing. Since landing the original CL [1], we have not added any conceptual or technical dependencies on the change. Hence, we can simply change these tasks back to having USER_VISIBLE priority. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3225938 (cherry picked from commit b78b12a) Bug: 1279756 Change-Id: I4f6e62ab64bbd03d0ecfddd2074b67a8caed0dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329602 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#951536} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338914 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/4758@{#38} Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Requires-Testing: True Change-Id: I162579bfbc861cd9186feb65ddc8358b8aff3f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650883 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5060@{#38} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
https://chromium.googlesource.com/webm/libwebp.git/+log/3c4a0fbfbcc6..7366f7f394af $ git log 3c4a0fbfb..7366f7f39 --date=short --no-merges --format='%ad %ae %s' 2022-07-20 jzern lossless: fix crunch mode w/WEBP_REDUCE_SIZE 2022-07-20 jzern webp-lossless-bitstream-spec,cosmetics: normalize capitalization Created with: roll-dep src/third_party/libwebp/src (cherry picked from commit 2278a69) Bug: chromium:1345547 Bug: chromium:1345595 Bug: chromium:1345772 Bug: chromium:1345804 Change-Id: I1dfb15d67ef0acb9c418fad0c4e1f89bb9e51239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781110 Reviewed-by: Urvang Joshi <urvang@chromium.org> Commit-Queue: Urvang Joshi <urvang@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1027089} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787433 Cr-Commit-Position: refs/branch-heads/5195@{#38} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
(cherry picked from commit d7a3d08) Bug: b:239935283 Change-Id: I83798e4cc35fd072f907af3864c5afa3e382fd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838817 Reviewed-by: Roman Sorokin <rsorokin@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1037159} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845390 Reviewed-by: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/branch-heads/5249@{#38} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
This reverts commit f98b161. Reason for revert: Causing crashes. crbug.com/1370723 Original change's description: > [Color Pipeline] Fix white flashes on NTP in dark mode. > > The colors in the WebUIDataSource need to be updated if the > ColorProvider changes. In the linked bug, on dark mode on Linux > the NewTabPageUI may be constructed when the system theme still > registers as light mode resulting in the DefaultColorProviderSource > having a light mode ColorProviderKey. This value will be set correctly > to have the BrowserView as the ColorProviderSource when the > WebContents of the new tab page is added to the TabStripModel (based on the work in this CL: crrev.com/c/3751977). However, we also need to make sure the background color is updated. > > This CL removes the need for the NewTabPageUI to be a > ThemeServiceObserver and NativeThemeObserver since the only theme > aspects that was dealt with were related to the ColorProvider and > we will receive appropriate ColorProvider changed notifications > when the NativeTheme and ThemeService are updated. > > > Bug: 1364269 > Change-Id: Id0337bf6f4c45cd9bf8d2d01029727c49faf3978 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902260 > Commit-Queue: Elaine Chien <elainechien@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1049715} (cherry picked from commit 043aad5) Bug: 1364269, 1374951 Change-Id: Ie3c2370eca696ea17961e731c3f730d181cc302c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956664 Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1059580} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3960598 Auto-Submit: Elaine Chien <elainechien@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#38} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
Record metrics when starting sign-in flow from feed card sign-in promo UI and the feed bottom sign-in card. Record metrics when the feed card sign-in promo UI (helf sheet) is shown. (cherry picked from commit 52884be) Bug: 1401487 Change-Id: Ia702c29fb4947d90774f2aaaa383fb11b0b8c3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112667 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Adam Arcaro <adamta@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1084493} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117180 Cr-Commit-Position: refs/branch-heads/5481@{#38} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
…ime within time range Time column in attribution-rate limit data changed from attribution time to source time in crrev.com/c/4184678. However, the time-ranged data deletion should be based on attribution time as well for proper clean up. (cherry picked from commit 5b67d4e) Bug: 1410756 Change-Id: Iaffda79594fb2a55920420809278ae92c6471e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4197849 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1098168} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4206030 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#38} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
… finishes This CL marks the item as "actioned on" only if it is finished when viewed in the main view. Previously, opening the main view with an ongoing download would mark that downloads as "actioned on", so it would not pop the partial bubble upon completion. This is bad because the user might forget about a large download. After this change, if the item is still in progress when the main view is opened, it is not marked as "actioned on" and will still trigger the partial view upon completion (if there are no other in-progress downloads). (cherry picked from commit fcb377e) Bug: 1419000 Change-Id: I51057827f000fe12bfa0c2e31dda17b3bf9a8324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291368 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1109899} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4294542 Auto-Submit: Lily Chen <chlily@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{#38} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
It's not clear that such an invariant can be enforced. There could be an issue cleaning up BITS files but can't assert on such runtime condition. (cherry picked from commit c25477e) Fixed: 1427446 Change-Id: I91dce63e50f28ad63360bbc1a06fbd9760930457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369790 Auto-Submit: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1121944} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374739 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sorin Jianu <sorin@chromium.org> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Auto-Submit: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5672@{#38} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
…istogram." This reverts commit 804d774. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1440580 Issue 1440580: Chrome: Crash Report - blink::ChildURLLoaderFactoryBundle::CreateLoaderAndStart Original change's description: > Remove Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite histogram. > > Remove the entry from histograms.xml, the metric logging in resource_fetcher.cc and associated tests in resource_fetcher_test.cc. > > > Bug: 1385063 > Change-Id: Ic94e11465b22d923a4d44289cb71fb60b888019b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4460611 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Mathijs Affourtit <maffourtit@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1135168} Bug: 1385063 Change-Id: Ib4b0fea722ea6ca253fc4078266e29acdffd3ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4484559 Owners-Override: Srinivas Sista <srinivassista@chromium.org> Reviewed-by: Harry Souders <harrysouders@google.com> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{#38} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Latest build fails to play Sirius, Tunein, Youtube and probably others.... 941561 works while 943402 doesn't..... on Os x Lion 10.7.5
Is this a candidate for bug reporting at https://crbug.com/new ....?
The text was updated successfully, but these errors were encountered: