Canary Crashes on Launch since....971429 #49
Comments
|
... and we're BACK.... |
|
.... & we're NOT.... 973011 crashes on session restore...... |
So, is the remaining issue a duplicate of #50? (It would be great to close some of these issues.) |
No this is not the same & fixed....closing... |
blueboxd
pushed a commit
that referenced
this issue
Jun 22, 2022
This change adds a new entry to ManagePasswordsReferrer enum and records PasswordManager.ManagePasswordsReferrer metric on iOS and desktop. On Android the behaviour is unchanged as metric is recorder later. (cherry picked from commit db7aa49) Bug: 1324293 Change-Id: I4af0512fce275406d99594438a796486e00d2b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648063 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003734} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3647876 Cr-Commit-Position: refs/branch-heads/5060@{#49} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd
pushed a commit
that referenced
this issue
Aug 31, 2022
This CL modified the default value of the connection type of network change notifier in Lacros to CONNECTION_UNKNOWN from CONNECTION_NONE. crrev.com/c/3761737 changes the default value from UNKNOWN to NONE which causes NetworkQualityEstimator to break. Note that this CL modifies the connection type default value to what it was before. (cherry picked from commit 6c24425) Bug: 1346567 Change-Id: Iaa4eff0b8d55859ec8858056068ebafd6c70baa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780024 Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1028168} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3782558 Auto-Submit: Eriko Kurimoto <elkurin@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5195@{#49} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd
pushed a commit
that referenced
this issue
Sep 29, 2022
This CL integrates the autotriggering side search side panel feature
with the feature egagement backend. This is only done for the unified
side panel as experimentation will happen after this feature has
fully rolled out.
ShouldAutomaticallyTriggerAfterNavigation() has been added to the
unified side panel controller to determine whether or not we should
attempt to automatically trigger the side panel based on the
following conditions:
1. The associated tab is the currently active browser tab
2. The side panel is not currently open to side search
3. The navigation is renderer initiated (i.e. not an omnibox
or bookmark navigation)
4. We have navigated back to the same SRP within the tab 2
number of times (default, configurable by finch param)
5. The currently committed navigation is the first navigation
away from the SRP
The automatic triggering behavior is also configurable via the
feature engagement backend. This can be used to control the
window in which auto-triggering is reattempted and how frequently
this occurs.
int returned_to_previous_srp_count() has also replaced
bool returned_to_previous_srp() in the tab helper to allow for
count based (rather than boolean based) tracking for the number
of times users return to the same SRP.
To test enable IPH_SideSearchAutoTriggering as the
in-product-help-demo-mode-choice in chrome://flags and use the
following on the command line (ignore the newlines):
--enable-features=
SideSearch,
SideSearchDSESupport,
UnifiedSidePanel,
SideSearchAutoTriggering:SideSearchAutoTriggeringReturnCount/1
Follow up will add additional metrics and tests.
(cherry picked from commit 35268ca)
Bug: 1354016
Change-Id: Id6890e0dbe045a55137d07f311d498da62839454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835658
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1037325}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850822
Cr-Commit-Position: refs/branch-heads/5249@{#49}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd
pushed a commit
that referenced
this issue
Nov 30, 2022
This CL updates the header of notification permissions module and makes it responsive to length of the list. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1345920#c42 Besides that this CL fixes the calculation bug for Sunday in notification_permission_review_service.cc. (cherry picked from commit 00f834ea91f55625f444254af8cc8e86a290ce1b) Bug: 1345920 Change-Id: If63d0560117ad746d2378e4b37ed23db8457de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3936630 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Auto-Submit: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by: Rainhard Findling <rainhard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1059213} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3955760 Cr-Commit-Position: refs/branch-heads/5359@{#49} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd
pushed a commit
that referenced
this issue
Feb 8, 2023
On dropping frames during AVC streaming, mmco 1 might be referring to a short ref picture that does not exist. Instead of exiting the picture marking process, allow next mmco to be performed with HW decoder. (cherry picked from commit 7300c15) Bug: 1394965 Change-Id: I5a9935b229de4452cd25fe263f683bbfb45f2af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114175 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1085512} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119381 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/branch-heads/5481@{#49} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd
pushed a commit
that referenced
this issue
Mar 7, 2023
…ark-111.0.5558.0-r1 to 111-5481.41-1674472805-benchmark-111.0.5563.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0c7f8ca8f53cefefacf97b67c04cba019e053928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208651 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#49} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd
pushed a commit
that referenced
this issue
Apr 14, 2023
Change-Id: I4ace1cb37bb3be37acaadf5567ea60c3e29c0c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296734 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{#49} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd
pushed a commit
that referenced
this issue
May 9, 2023
This CL adds the "baseline" ref color palette to the ref color mixer. This palette should be used for ref color tokens in the situation where no user_color has been explicitly defined. The logic the GM3 team used to derive this palette has since changed and the material_color_utilities library cannot be used to recreate the desired colors. As a result the original palette has been hardcoded as a fallback option for the unthemed case. See go/chrome-desktop-tokens for the baseline guidance. (cherry picked from commit 4a12391) Bug: 1427301 Change-Id: Icd1857bb381a4224d976812671b78b20308d2bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4366884 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1121521} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375041 Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/branch-heads/5672@{#49} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd
pushed a commit
that referenced
this issue
May 27, 2023
…0-benchmark-114.0.5715.0-r2 to 114-5707.0-1682337030-benchmark-114.0.5735.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I45140d8ad9584b601d0e91f6fe50103042580dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489187 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#49} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
happening again.....
Process: Chromium [958]
Path: /Applications/Chromium.app/Contents/MacOS/Chromium
Identifier: org.chromium.Chromium
Version: 100.0.4892.0 (4892.0)
Code Type: X86-64 (Native)
Parent Process: launchd [119]
Date/Time: 2022-02-16 06:53:46.090 -0500
OS Version: Mac OS X 10.7.5 (11G63)
Report Version: 9
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Application Specific Information:
abort() called
objc[958]: garbage collection is OFF
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff90a3182a __kill + 10
1 libsystem_c.dylib 0x00007fff852e2a9c abort + 177
2 org.chromium.Chromium 0x0000000104f6237c (anonymous namespace)::FatalError(char const*, ...) + 252
3 org.chromium.Chromium 0x0000000104f62267 main + 279
4 org.chromium.Chromium 0x0000000104f62144 start + 52
Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x0000000000000000 rbx: 0x00007fff64b5fb70 rcx: 0x00007fff64b5fb58 rdx: 0x0000000000000000
rdi: 0x00000000000003be rsi: 0x0000000000000006 rbp: 0x00007fff64b5fb80 rsp: 0x00007fff64b5fb58
r8: 0x0000000104fd9a00 r9: 0x0000000000000000 r10: 0x00007fff90a32e62 r11: 0x0000000000000206
r12: 0x0000000105009ef0 r13: 0x00007f8a09807400 r14: 0x0000000104f84302 r15: 0x00007fff64b5fb90
rip: 0x00007fff90a3182a rfl: 0x0000000000000206 cr2: 0x0000000104ff0000
Logical CPU: 0
Originally posted by @pjpreilly in #45 (comment)
The text was updated successfully, but these errors were encountered: