Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser tabs randomly don't load contents an undefined amount of time later (Updated) #80

Open
scrutinizer11 opened this issue Aug 11, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@scrutinizer11
Copy link

scrutinizer11 commented Aug 11, 2022

Describe the bug
With one or several tabs that stay open for some time, it either clears the page of its contents or the page becomes unresponsive (non-scrollable).

To Reproduce
Steps to reproduce the behavior:

  1. Open one or several pages: if the latter make them load in different tabs.
  2. Do your work as you usually would with one of the tabs active or let it alone.
  3. Switch to the other tabs after a sensibly long time or leave the active tab opened.
  4. The tab that's just switched to or the active tab either gets blank, can't refresh or is non-responsive (frozen) so that basic input is impossible.

Expected behavior
Normal behaviour.

Desktop (please complete the following information):

  • OS: MacOS X Lion, OS X Mavericks
  • Build 104.0.5112.79 and later
    Screen Shot 2022-08-20 at 21 14 53

@blueboxd @Wowfunhappy

@scrutinizer11 scrutinizer11 added the bug Something isn't working label Aug 11, 2022
@scrutinizer11 scrutinizer11 changed the title Multiple open browser tabs don't load contents on YouTube an undefined amount of time later Multiple open browser tabs don't load contents an undefined amount of time later Aug 20, 2022
@scrutinizer11 scrutinizer11 changed the title Multiple open browser tabs don't load contents an undefined amount of time later Browser tabs don't load contents an undefined amount of time later Aug 20, 2022
@scrutinizer11 scrutinizer11 changed the title Browser tabs don't load contents an undefined amount of time later Browser tabs randomly don't load contents an undefined amount of time later Aug 20, 2022
@scrutinizer11 scrutinizer11 changed the title Browser tabs randomly don't load contents an undefined amount of time later Browser tabs randomly don't load contents an undefined amount of time later (Updated) Aug 20, 2022
blueboxd pushed a commit that referenced this issue Aug 31, 2022
(cherry picked from commit f894c02)

Fixed: 1347186
Change-Id: Ia1c3cf0f2cf8ad5a3d98d4ca5c09edccc5e26d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785075
Reviewed-by: Victor Vianna <victorvianna@google.com>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1028465}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3790280
Cr-Commit-Position: refs/branch-heads/5195@{#80}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
@fhgwright
Copy link

I see this frequently in pretty much every version of Chromium Legacy, on OS 10.9.5. Reloading the page fixes it, though it sometimes fails again. What I suspect is happening is that it decides it needs to rerender the page from scratch, so it clears the page in preparation for doing that, but then hangs indefinitely before actually doing the rerendering. It happens most commonly in pages with lots of obnoxious ads. Sometimes one can get around it by reloading the page and then stopping the reload before it gets a chance to load all the troublesome content.

I've wondered if there might be some relation between this and #44, since both seem to relate to waiting that doesn't work properly, though this case doesn't crash.

@Wowfunhappy
Copy link
Sponsor

Wowfunhappy commented Sep 18, 2022

Reloading the page fixes it, though it sometimes fails again.

If it keeps failing, trying copying the URL, closing the tab, opening a new tab, and pasting the URL into the new tab. I don't know why this helps, but it does.

If it still fails, quitting and re-opening Chromium Legacy always works.

blueboxd pushed a commit that referenced this issue Sep 29, 2022
Matches the extension length restriction for FilePickerOptions

(cherry picked from commit 028168a)

Bug: 1354505
Change-Id: I37d61aed0bcebbdf05d131a33cc0f14b117f04e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841864
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Daseul Lee <dslee@chromium.org>
Auto-Submit: Austin Sullivan <asully@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1037829}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851062
Cr-Commit-Position: refs/branch-heads/5249@{#80}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
Fixed bug where the page action chip incorrectly stays open after
navigating to another tab also with a chip. Page action chip now
shows in the collapsed state after navigating to another tab and coming
back.

Bug also mentions the issue where the text of the chip is not appearing
that is believed to be caused by navigating to another tab while the
chip is expanded. I was unable to reliably reproduce that issue and thus
unable to determine the cause of that bug; unsure if this CL is also
able to fix that issue.

(cherry picked from commit bc1a8b8)

Bug: 1373168
Change-Id: Ibb1abc3558153ca89f1d0e45e2939a8600058fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3949481
Commit-Queue: Steven Luong <stluong@chromium.org>
Reviewed-by: Alison Gale <agale@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1060075}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3964057
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5359@{#80}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
BUG=1403291

(cherry picked from commit 52e3bd9)

Change-Id: I4dcfab87907b38c43f5152292e3d66296f910aeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4122979
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1087059}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127289
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#80}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
(cherry picked from commit 903a579)

Bug: 1411224
Change-Id: Iea2d3d70b2d657bb2561cdeb1b82ab2663decb57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200655
Auto-Submit: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1099186}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4212289
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Cr-Commit-Position: refs/branch-heads/5563@{#80}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
The histograms record the total number of off-store extensions on a client and the duration of the data collection process.

(cherry picked from commit 2c37b98)

Bug: 1384755
Change-Id: I35ae77e8749070db3128e031cf1b25da848d5e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288492
Commit-Queue: Richard Chen <richche@google.com>
Reviewed-by: thefrog <thefrog@chromium.org>
Reviewed-by: Anunoy Ghosh <anunoy@chromium.org>
Reviewed-by: Zack Han <zackhan@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1110533}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4298173
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#80}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
This undoes some of https://chromium-review.googlesource.com/c/chromium/src/+/3926235
with the goal of investigating smoothness regressions
under ExplicitHighResolutionTimerWin.
This changes has no effect outside of ExplicitHighResolutionTimerWin.

(cherry picked from commit 09dff5a)

Bug: 700165
Change-Id: I5313673aff4086cee337463aa95e2ba5247efff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4358994
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121930}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374333
Cr-Commit-Position: refs/branch-heads/5672@{#80}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
…0-benchmark-114.0.5735.10-r1 to 114-5707.0-1682337030-benchmark-114.0.5735.11-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ia69e9c2e806ef199d479fe3f05cc89f84029930f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495177
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#80}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
blueboxd pushed a commit that referenced this issue Sep 10, 2023
The redirect was broken by CL: https://crrev.com/c/4732981

This bug crept in because of two issues:
1) `ShowDiceSigninTab()` had a default value for the redirect parameter,
   and would do no redirection by default. This default behavior made it
   hard to update all callers in the previous CL and one of them was
   missed.
2) The integration test was using the deprecated `ShowSignin()` function
   instead of `ShowDiceEnableSyncTab()`, and as a result the broken
   function was not tested.

This CL addresses the two issues:
- removing the default empty redirect, to make sure all callers pass the
  right value explicitly.
- the test is switched away from the deprecated function and tests the
  recommended function instead. The deprecated function is losing some
  coverage, but it still has some, and there is only one caller of that
  function anyway. The deprecated function will be removed as a follow
  up.

The CL also improves comments for the redirect behavior.

(cherry picked from commit 85e079b)

Fixed: 1472219
Change-Id: I468483145beaebe54d43bf38527da9bbd2947b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4773361
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182575}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4774723
Auto-Submit: David Roger <droger@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5938@{#80}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants