Created issue templates for bug and crash reports #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueboxd
pushed a commit
that referenced
this pull request
Mar 31, 2022
…OM node A <slot> that is not in a shadow root should be treated like any other element. Almost any code that just checks for a slot element without using ToHTMLSlotElementIfSupportsAssignmentOrNull()is probably incorrect. This seems to help improve performance in issue 1281936, but it's not clear why. However, it is more correct code and we should land it whether it improves performance at all. We should not be unnecessarily truncating subtrees that use a <slot> element (cherry picked from commit 3ff4325) (cherry picked from commit 44a09bf) Bug: 1281936 Change-Id: Icb954d8706c3dafc0aaa1fca8d4f3fb9d8c2b44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472410 Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/main@{#973886} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3484983 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/4896@{#46} Cr-Original-Branched-From: 1f63ff4-refs/heads/main@{#972766} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3507497 Reviewed-by: Abigail Klein <abigailbklein@google.com> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/branch-heads/4844@{#998} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
|
Sorry for late 🙇 |
blueboxd
pushed a commit
that referenced
this pull request
Jun 22, 2022
…-103.0.5045.0-r1 to 103-5045.0-1652693936-benchmark-103.0.5060.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie8bdcd7e68f596329d15611a74fabaeeec841656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652143 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5060@{#46} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd
pushed a commit
that referenced
this pull request
Aug 31, 2022
…s empty It is possible to get an empty url from recommended site when there's a fetching error. It rarely happens but we need to add a protect to it, otherwise we'll have a crash when trying to add an empty NSURL as a key to the dictionary. (cherry picked from commit 0bed9fd) Bug: 1347206 Change-Id: If07034f8f3496b0c138ec9091e8e524e1626b794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3784392 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1027956} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788506 Cr-Commit-Position: refs/branch-heads/5195@{#46} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd
pushed a commit
that referenced
this pull request
Sep 29, 2022
(Cherry pick to M106 branch.) The feature has been launched, so the flag is now enabled by default, but we'd like to keep the flag as a kill-switch in case something comes up with the launch. (cherry picked from commit 9440c1d) Bug: None Change-Id: Ie5645aade1f5452beae1866d1553e763cec26f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846032 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1037820} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850022 Cr-Commit-Position: refs/branch-heads/5249@{#46} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd
pushed a commit
that referenced
this pull request
Nov 30, 2022
This splits PENDING_PROMPT to PENDING_PROMPT_NOT_CANCELED and PENDING_PROMPT_CANCELED, tracks whether the beforeinstallprompt event is canceled. (cherry picked from commit 457c1cc) Bug: 1371091 Change-Id: I13c66cbe808f86d289cd1eb2daa875b743923e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3944931 Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1058980} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3958994 Cr-Commit-Position: refs/branch-heads/5359@{#46} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd
pushed a commit
that referenced
this pull request
Feb 8, 2023
Change-Id: Id827f22f3fc8acfff897b391dfc12b99ee737f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121241 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5481@{#46} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd
pushed a commit
that referenced
this pull request
Mar 7, 2023
Change-Id: I9cf2f2a16f9161249ea9cc3eec6b9b002289b552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208389 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#46} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd
pushed a commit
that referenced
this pull request
Apr 14, 2023
Small fix to correct a problem with two mislabeled constraints for the top of Feed sync promo. (cherry picked from commit 612005d) Bug: 1419064 Change-Id: Id4bc90721760a15b6c36544bb1d4052688d6d1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4290023 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Guillem Perez <guiperez@google.com> Reviewed-by: Adam Arcaro <adamta@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1109724} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296696 Cr-Commit-Position: refs/branch-heads/5615@{#46} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd
pushed a commit
that referenced
this pull request
May 9, 2023
(cherry picked from commit 85f313d) Bug: 1421334 Change-Id: I3754d609c0e40eba21f5f136804895258f7053ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4367248 Commit-Queue: thefrog <thefrog@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1121664} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374937 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: thefrog <thefrog@chromium.org> Cr-Commit-Position: refs/branch-heads/5672@{#46} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd
pushed a commit
that referenced
this pull request
May 27, 2023
If a view controller presented on top of the browser, the sign-in view should not be presented. It is possible that web page takes time to load, and by the time it is loaded, the user might have started another action. For example, they might have already opened the sign-in view from the settings. (cherry picked from commit 6280f13) Fixed: 1399464 Change-Id: Ic8b66674f3a5587201757073c030cf45d2d064a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4442168 Reviewed-by: Arthur Milchior <arthurmilchior@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1136091} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4487631 Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{#46} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no issue templates in the repository and I feel like the lack of it might intimidate people and prevent them from posting new issues. Besides, having the template can always be useful and forgetting about needed information won't be a problem. I created two very basic templates for a normal bug report and a crash report.