Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add camera(s) from the list view fix #567

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add camera(s) from the list view fix #567

wants to merge 5 commits into from
+48 −3

Conversation

curtishall
Copy link
Member

Closes #566

@curtishall
Copy link
Member Author

Fixed #566 and closes

@curtishall curtishall mentioned this pull request Jan 29, 2023
Closed
abdullahfarwees
abdullahfarwees reviewed Feb 21, 2023
View reviewed changes
Copy link

@abdullahfarwees abdullahfarwees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_dir_permission.sh script includes several commented out lines that are not currently being executed. These lines were likely used during development or testing of the script. Do we need to take forward those lines into the MASTER branch ?

@curtishall
Copy link
Member Author

@divsbhalala Please remove the commented out sections in the shell script

abdullahfarwees
abdullahfarwees approved these changes Feb 23, 2023
View reviewed changes
Copy link

@abdullahfarwees abdullahfarwees left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahfarwees abdullahfarwees abdullahfarwees approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add cameras using 'Discover' method
3 participants
@curtishall @abdullahfarwees @divsbhalala