Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource-config.json for GraalVM Native Image support #51

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jan 16, 2023

This PR adds resource-config.json for GraalVM Native Image support.

@paulrutter
Copy link
Contributor

@izeye can you elaborate on what this PR does?
And update the readme and changelog with instructions on how to use it?

@izeye
Copy link
Contributor Author

izeye commented Jan 20, 2023

@paulrutter Sorry for the lack of details.

This PR tries to support GraalVM Native Image by providing metadata for resources (ie. browscap-xxx.zip).

I tried to illustrate the difference between with and without the file with the following samples: native-image branch and native-image-with-resource-config-json branch

Please see their README.md files.

I also updated the README.md and the CHANGELOG.txt as you requested.

Please let me know if there's anything else I need to do.

@paulrutter
Copy link
Contributor

Thanks, i'll try to merge it next week and release it as 1.4.0.

@paulrutter
Copy link
Contributor

paulrutter commented Jan 20, 2023

If i understand correctly, you could also fix it by using an alternative constructor where you feed in the browscap zip yourself: public UserAgentService(final String zipFilePath) {

Or an inputstream https://github.com/blueconic/browscap-java/blob/master/src/main/java/com/blueconic/browscap/UserAgentService.java#L47

paulrutter added a commit that referenced this pull request Jan 24, 2023
- Added support for GraalVM Native Image (#51)
- Update dependencies
@paulrutter paulrutter merged commit 62e7492 into blueconic:master Jan 24, 2023
@paulrutter
Copy link
Contributor

Released as version 1.4.0, pushing into sonatype now.

@izeye izeye deleted the native branch January 25, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants