Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove deprecated methods #1583

Merged
merged 2 commits into from Aug 16, 2023
Merged

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Jul 25, 2023

Description

I missed to remove the deprecated methods in #1453.

We can either:

  • Add a minor version 5.1.0 for a release, as the migration instructions for the introduced breaking changes were already explained in the previous PRs.
  • As it's breaking, we could release 6.0.0 instantly
  • Wait with this PR and merge it until another breaking change cannot be circumvented, as this change is not urgent.

I'd propose the first or the last option.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Migration instructions

See #1352 and #1443

Related Issues

Closes #1453

@Gustl22 Gustl22 requested a review from spydon July 25, 2023 15:36
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Jul 31, 2023

@spydon any opinion on this? Thank you for reviewing ;D

@spydon
Copy link
Member

spydon commented Aug 1, 2023

@spydon any opinion on this? Thank you for reviewing ;D

Hmm, since we don't really have a strategy for this library yet I think you can choose whichever you think fits the best. :)

@Gustl22 Gustl22 changed the title refactor!: remove deprecated methods refactor!: Remove deprecated methods Aug 1, 2023
@Gustl22 Gustl22 marked this pull request as ready for review August 16, 2023 13:21
@Gustl22 Gustl22 removed the request for review from spydon August 16, 2023 13:21
@Gustl22 Gustl22 merged commit 8d0cbed into main Aug 16, 2023
14 checks passed
@Gustl22 Gustl22 deleted the gustl22/1453-remove-deprecated branch August 16, 2023 15:32
Gustl22 added a commit that referenced this pull request Oct 6, 2023
This was referenced Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated methods in v5.0.0
2 participants