Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Should properly look for element when removing #29

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: Should properly look for element when removing #29

merged 1 commit into from
Apr 16, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Apr 16, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8713206732

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 96.842%
Files with Coverage Reduction New Missed Lines %
lib/ordered_set.dart 1 96.23%
Totals Coverage Status
Change from base Build 6152940694: 0.0%
Covered Lines: 92
Relevant Lines: 95
💛 - Coveralls

@spydon spydon merged commit ed2d5a3 into main Apr 16, 2024
4 checks passed
@spydon spydon deleted the fix/removal-should-work branch April 16, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter left review comments

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Children are not ordered by priority following add and remove
4 participants
@spydon @coveralls @erickzanardo @luanpotter