Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink PhotoView usage API #53

Closed
renancaraujo opened this issue Nov 18, 2018 · 1 comment
Closed

Rethink PhotoView usage API #53

renancaraujo opened this issue Nov 18, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
0.1.0

Comments

@renancaraujo
Copy link
Member

Right now we have 10 options on our constructor. For each one we change, we have to update option in PhotoViewInline as well. It is becoming hard to maintain, so I think we should change from PhotoViewInline() to PhotoView.inline() since the inline has the same visual outcome as Photoview
@renancaraujo renancaraujo added the enhancement New feature or request label Nov 18, 2018
@renancaraujo
Copy link
Member Author

That will be changed before 0.1.0

@renancaraujo renancaraujo added this to the 0.1.0 milestone Nov 18, 2018
@renancaraujo renancaraujo changed the title Revise PhotoView usage API Rethink PhotoView usage API Nov 18, 2018
@renancaraujo renancaraujo mentioned this issue Nov 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@renancaraujo