Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing modifier queries were inverted #20

Merged
merged 1 commit into from
Jun 5, 2019
Merged

fix: missing modifier queries were inverted #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fhir-qb/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ class QueryBuilder {
// If the modifier is 'missing', nothing else matters, we're just checking if the field exists.
if (modifier === matchModifiers.missing) {
value = sanitize.sanitizeBoolean({ field, value });
subQuery = this.qb.buildExistsQuery({ field, exists: value });
subQuery = this.qb.buildExistsQuery({ field, exists: !value });
} else {
// Otherwise, construct a query based on data type
switch (type) {
Expand Down
4 changes: 2 additions & 2 deletions packages/fhir-qb/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4641,7 +4641,7 @@ describe('Mongo Tests', () => {
includeArchived,
});
const expectedResult = [
{ $match: { $and: [{ $or: [{ foo: { $exists: true } }] }] } },
{ $match: { $and: [{ $or: [{ foo: { $exists: false } }] }] } },
{ $match: { 'meta._isArchived': false } },
{
$facet: {
Expand Down Expand Up @@ -4678,7 +4678,7 @@ describe('Mongo Tests', () => {
includeArchived,
});
const expectedResult = [
{ $match: { $and: [{ $or: [{ foo: { $exists: false } }] }] } },
{ $match: { $and: [{ $or: [{ foo: { $exists: true } }] }] } },
{ $match: { 'meta._isArchived': false } },
{
$facet: {
Expand Down